Skip to content

feat(pop-api): further implementation of nfts api #41

feat(pop-api): further implementation of nfts api

feat(pop-api): further implementation of nfts api #41

GitHub Actions / clippy succeeded Mar 7, 2024 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check warning on line 373 in node/src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (14/7)

warning: this function has too many arguments (14/7)
   --> node/src/service.rs:358:1
    |
358 | / fn start_consensus(
359 | |     client: Arc<ParachainClient>,
360 | |     block_import: ParachainBlockImport,
361 | |     prometheus_registry: Option<&Registry>,
...   |
372 | |     announce_block: Arc<dyn Fn(Hash, Option<Vec<u8>>) + Send + Sync>,
373 | | ) -> Result<(), sc_service::Error> {
    | |__________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
8  | |
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 191 in runtime/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this is a decimal constant

warning: this is a decimal constant
   --> runtime/src/lib.rs:191:16
    |
191 |     spec_version: 00_01_00,
    |                   ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
    = note: `#[warn(clippy::zero_prefixed_literal)]` on by default
help: if you mean to use a decimal constant, remove the `0` to avoid confusion
    |
191 |     spec_version: 1_00,
    |                   ~~~~
help: if you mean to use an octal constant, use `0o`
    |
191 |     spec_version: 0o1_00,
    |                   ~~~~~~

Check warning on line 7 in runtime/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this import is redundant

warning: this import is redundant
 --> runtime/src/extensions.rs:7:1
  |
7 | use log;
  | ^^^^^^^^ help: remove it entirely
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
  = note: `#[warn(clippy::single_component_path_imports)]` on by default

Check warning on line 13 in pop-api/src/v0/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

question mark operator is useless here

warning: question mark operator is useless here
  --> pop-api/src/v0/mod.rs:11:2
   |
11 | /     Ok(state::read(RuntimeStateKeys::ParachainSystem(
12 | |         ParachainSystemKeys::LastRelayChainBlockNumber,
13 | |     ))?)
   | |________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
   = note: `#[warn(clippy::needless_question_mark)]` on by default
help: try removing question mark and `Ok()`
   |
11 ~     state::read(RuntimeStateKeys::ParachainSystem(
12 ~         ParachainSystemKeys::LastRelayChainBlockNumber,
13 ~     ))
   |

Check warning on line 9 in pop-api/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this import is redundant

warning: this import is redundant
 --> pop-api/src/lib.rs:9:1
  |
9 | use scale;
  | ^^^^^^^^^^ help: remove it entirely
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
  = note: `#[warn(clippy::single_component_path_imports)]` on by default