Skip to content

support connection callbacks #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support connection callbacks #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ type ResponseValidator func(c *Client, resp *http.Response) error
type Client struct {
Retry time.Time
ReconnectStrategy backoff.BackOff
disconnectcb ConnCallback
connectedcb ConnCallback
Disconnectcb ConnCallback
Connectedcb ConnCallback
subscribed map[chan *Event]chan struct{}
Headers map[string]string
ReconnectNotify backoff.Notify
Expand Down Expand Up @@ -218,17 +218,17 @@ func (c *Client) readLoop(reader *EventStreamReader, outCh chan *Event, erChan c
return
}
// run user specified disconnect function
if c.disconnectcb != nil {
if c.Disconnectcb != nil {
c.Connected = false
c.disconnectcb(c)
c.Disconnectcb(c)
}
erChan <- err
return
}

if !c.Connected && c.connectedcb != nil {
if !c.Connected && c.Connectedcb != nil {
c.Connected = true
c.connectedcb(c)
c.Connectedcb(c)
}

// If we get an error, ignore it.
Expand Down Expand Up @@ -280,12 +280,12 @@ func (c *Client) Unsubscribe(ch chan *Event) {

// OnDisconnect specifies the function to run when the connection disconnects
func (c *Client) OnDisconnect(fn ConnCallback) {
c.disconnectcb = fn
c.Disconnectcb = fn
}

// OnConnect specifies the function to run when the connection is successful
func (c *Client) OnConnect(fn ConnCallback) {
c.connectedcb = fn
c.Connectedcb = fn
}

func (c *Client) request(ctx context.Context, stream string) (*http.Response, error) {
Expand Down