Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #275

Merged
merged 6 commits into from
Jan 28, 2024
Merged

Dev #275

merged 6 commits into from
Jan 28, 2024

Conversation

MansMeg
Copy link
Contributor

@MansMeg MansMeg commented Jan 28, 2024

Fail gracefully for web connections.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (599127c) 90.12% compared to head (d7e4424) 89.80%.
Report is 4 commits behind head on master.

Files Patch % Lines
R/pxweb_interactive.R 50.00% 5 Missing ⚠️
R/pxweb.R 40.00% 3 Missing ⚠️
R/pxweb_get.R 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   90.12%   89.80%   -0.32%     
==========================================
  Files          32       32              
  Lines        1802     1825      +23     
==========================================
+ Hits         1624     1639      +15     
- Misses        178      186       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MansMeg MansMeg merged commit 31e5795 into master Jan 28, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant