-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(zora): add mint plugin #117
Conversation
🦋 Changeset detectedLatest commit: 237ea18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
test('should return a valid action filter', () => { | ||
|
||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should at a filter test - yeah good callout
packages/zora/src/index.ts
Outdated
} from './Zora.js' | ||
|
||
// Replace *project* with the name of the project | ||
export const {Zora}: IActionPlugin = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be destructured
packages/zora/src/test-setup.ts
Outdated
recipient: '0xd31143Ca8503b25DdE780dc1B92E9aA61D0E326d', | ||
}), | ||
createTestCase(MINT_WITH_REWARDS_1155, 'when tokenId is incorrect', { | ||
tokenId: '1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tokenId expects a number here.
packages/synapse/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you meant to include this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deff not I should probably remove it lol
chainId: Chains.ZORA, | ||
contractAddress: '0x4c0c2DD31d2661E8BCeC60a42e803dCc6F81Baad'.toLowerCase() as Address, | ||
amount: '1', | ||
tokenId: '25', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tokenId should be a number
…stdk-plugins into mmackz-basepaint-patch
fix(basepaint): use updated mint action params
packages/zora/src/Zora.ts
Outdated
): Promise<TransactionFilter> => { | ||
const { chainId, contractAddress, tokenId, amount, recipient } = mint | ||
|
||
let andArray = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter wants this to be a const, since it does not get reassigned. Not really a big deal though as it still passes the tests.
…stdk-plugins into add_zora_plugin
…stdk-plugins into add_zora_plugin
There's two main contracts, one for 721 and one for 1155. This supports both.
The filter requires that a contract address is found since every mint goes through a different contract. There might be a way to get the full list but I don't think we want to support minting on any contract at this time.
It looks like there's collections with legacy contracts, I tried to support the ones I could find but it's possible that this plugin will break for collections launched too long into the past. Should work for all recent collections and all going forward.