Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Zora): add create action to Zora plugin #387

Merged
merged 7 commits into from
May 21, 2024
Merged

Conversation

mmackz
Copy link
Collaborator

@mmackz mmackz commented May 15, 2024

Creates a new create action for the Zora plugin. This action filter will detect any transaction which use the createContract function on the ZORA_1155_FACTORY contract. The is no additional parameters besides the chainId and contract address.

To-do

  • Create types for create action type in questdk.

@mmackz mmackz requested a review from a team as a code owner May 15, 2024 03:03
Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 2a5a478

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@rabbitholegg/questdk-plugin-zora Minor
@rabbitholegg/questdk-plugin-registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG - how do you wanna handle the Create Action params? This is failing cause of that seems

@mmackz mmackz merged commit 24e72da into main May 21, 2024
9 checks passed
@mmackz mmackz deleted the mmackz/zora-create branch May 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants