Skip to content

Enable State Override #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Enable State Override #405

merged 4 commits into from
Jun 21, 2024

Conversation

jonathandiep
Copy link
Contributor

Increases the balance when running simulateContract to prevent the low balance ContractFunctionExecutionError

ContractFunctionExecutionError: The total cost (gas * gas fee + value) of executing this transaction exceeds the balance of the account.

@jonathandiep jonathandiep requested a review from a team as a code owner May 21, 2024 17:35
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 01901e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@rabbitholegg/questdk-plugin-zora Patch
@rabbitholegg/questdk-plugin-registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines -285 to -315
// TODO: There's a bug in Viem preventing this behavior; log issue with them
// stateOverride: [{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure if there was a bug (at least in current version -- 2.9.23) since I was able to get this running fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING

Comment on lines -285 to -315
// TODO: There's a bug in Viem preventing this behavior; log issue with them
// stateOverride: [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING

@Quazia
Copy link
Contributor

Quazia commented Jun 21, 2024

@jonathandiep We safe to get this in main? Still looks good to me

@jonathandiep
Copy link
Contributor Author

@jonathandiep We safe to get this in main? Still looks good to me

I'll get it in today!

@jonathandiep jonathandiep force-pushed the jon/enable-state-override branch from ee6f6cb to 01901e3 Compare June 21, 2024 18:13
@jonathandiep jonathandiep merged commit e9c837d into main Jun 21, 2024
9 checks passed
@jonathandiep jonathandiep deleted the jon/enable-state-override branch June 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants