feat(utils): adds the complete action type #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ddbfdc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 49 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmackz
reviewed
May 22, 2024
| COMPLETE | ||
| */ | ||
| export type CompleteActionParams = { | ||
| boostId?: string |
There was a problem hiding this comment.
I think we will also want to take in the chainId as an actionParam.
There was a problem hiding this comment.
Im not sure if we can make it work for all networks at the same time?
There was a problem hiding this comment.
I added chainId as optional. It should allow us to enable for all networks. Will update if we need to enforce a chainId
mmackz
reviewed
May 22, 2024
packages/utils/src/types/actions.ts
Outdated
| actionType?: string | ||
| } | ||
|
|
||
| export const CompleteActionFormSchema = z.object({}) |
There was a problem hiding this comment.
The form schema is for the inputs we want to take in on manager, (at least this is how I understand it)
So we are going to want to have optional fields here for boostId and actionType
mmackz
reviewed
May 22, 2024
packages/utils/src/types/actions.ts
Outdated
| boostId: z.string().optional(), | ||
| actionType: z.string().optional(), | ||
| }) | ||
| .refine((data) => data.boostId != null || data.actionType != null, { |
There was a problem hiding this comment.
We want the chainId in here also (assuming we want to add it to actionParams)
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
CompleteAction Type