feat(Boost): add complete action to Boost plugin #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0f3a4f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 48 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonathandiep
force-pushed
the
jon/validate-complete
branch
2 times, most recently
from
6a937d0 to
42c7125
Compare
jonathandiep
changed the title
Quazia
approved these changes
May 28, 2024
| @@ -40,7 +40,6 @@ export default { | |||
| }, | |||
| ], | |||
| plugins: [ | |||
| polyfillNode(), | |||
There was a problem hiding this comment.
We're trying to move over to Vite for our build now (sorry for the whiplash) but why remove this for this PR?
There was a problem hiding this comment.
There was some weird build config (I think it was after importing axios into the boost plugin)
At some point, I took at look at the Neynar plugin and it didn't have the polyfillNode(). So I removed it here too and it worked
| 'At least one of chainId, boostId, or actionType must be provided', | ||
| }, | ||
| ) | ||
| export const CompleteActionDetailSchema = z.object({ |
There was a problem hiding this comment.
We can rely on this export once the utils are cleaned up vs copying it over the backend. No action needed mostly a reminder for me to go back and clean this up in the RH repo once that change is live.
jonathandiep
force-pushed
the
jon/validate-complete
branch
from
19dc031 to
0f3a4f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.