feat(thirdweb): add support for ThirdWeb mint plugin
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a5e9c0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Quazia
approved these changes
Jun 11, 2024
| @@ -0,0 +1,267 @@ | |||
| import { mint } from './ThirdWeb' | |||
| // import { getFees, mint, simulateMint } from './ThirdWeb' | |||
There was a problem hiding this comment.
Ive left the commented code so that I can easily run the non-mocked tests when needed. (the mocked tests are kind of useless 😅)
Wondering if maybe there is a better way to have non-mocked tests to be run locally.
| throw new Error('Invalid contract type') | ||
| } | ||
|
|
||
| export function formatAmount(amount: FilterOperator | undefined) { |
There was a problem hiding this comment.
This and the getMintAmount could both probably live in the utils package.
There was a problem hiding this comment.
Going to make a separate PR to add these functions to utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of
thirdwebmint action plugin for QuestDKThis PR introduces the integration of the
thirdwebmint plugin for QuestDK.About The Project
Thirdweb is a robust platform that streamlines the process of minting and managing NFTs. By providing easy-to-use tools and infrastructure, it empowers creators to mint, deploy, and manage their NFT collections efficiently.
Implementation Details
Thirdweb is available on most major L2 networks such as base and optimism
We have support for two types of contracts,
DropERC1155andOpenEditionERC721, both are quite similar, with the difference being the ERC1155 can utilize a tokenId parameter. Both use theclaimfunctions on their respective contracts.Sample Mints
Example Transactions