fix(pods): fix simulation errors when no tokenId is provided [BOOST-4097] #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b7f211 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Quazia
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
LGTM - it is getting the most recent token ID now. As a follow-on if we see more fails I still think it would make sense to iterate through the tokenIds when the simulate fails and tokenId hasn't been set but we can pull that lever based on subsequent issues SG?
Quazia
reviewed
Jun 11, 2024
Quazia
reviewed
Jun 11, 2024
packages/pods/src/Pods.test.ts
Outdated
| expect(fee.projectFee).toEqual(parseEther('0')) | ||
| expect(fee.actionFee).toEqual(parseEther('0.0007')) | ||
|
|
||
| // const { actionFee, projectFee } = await getFees(mintParams) |
Quazia
reviewed
Jun 11, 2024
Quazia
reviewed
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would receive an error when no tokenId was provided due to their not being a certain function
nextTokenIdnot being available on the ABI.There can still be issues if the latest tokenId is not in a mintable state.
fixes BOOST-4097