Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fabric): fix amount zero issue #473

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

mmackz
Copy link
Collaborator

@mmackz mmackz commented Jul 10, 2024

  • add check for num tokens in validation
  • fix amount zero issue
  • update types
  • adjust tests to catch error when no contract data is found

@mmackz mmackz requested a review from a team as a code owner July 10, 2024 05:18
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: a373fde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@rabbitholegg/questdk-plugin-fabric Minor
@rabbitholegg/questdk-plugin-registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So they have a variable minimum order required?

@mmackz
Copy link
Collaborator Author

mmackz commented Aug 8, 2024

So they have a variable minimum order required?

Depends on the minimum time required for a subscription (ie: 1 day, 1 week, etc)

The amount is static, meaning it stays the same for all mints.

@mmackz mmackz merged commit 9e81e1f into main Aug 8, 2024
9 checks passed
@mmackz mmackz deleted the mmackz/fabric/amount-zero branch August 8, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants