Feat: defined a type for exchange kinds #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the idea, but the current implementation changes the public API, and it's a breaking change. We can merge this PR when we plan to release 2.0. In the mean time, you can accomplish the same without declaring the |
|
It's ok. I'll keep the PR open.
These string constants were defined before. I just changed their name and added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The developer must type out the kind of exchange when declaring it, which could lead to typos. Also, the IDE or code editor did not help or suggest a type of exchange.
This way, selecting an exchange is more straightforward and helps maintain the code more easily.