m2k_cluster_sync: Add an application env. var. to disable the cluster repair mechanism #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repair mechanism [Why] The caller may want to forcibly reset a Khepri node without a clean unclustering, leaving other nodes connected and thinking they are still connected to the reset node. This is the case of RabbitMQ with it "force reset" command. [How] This application environment variable allows it to prever the repair mechanism to revert that reset and put the reset node back into the cluster.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 71.34% 71.54% +0.20%
==========================================
Files 13 13
Lines 705 710 +5
==========================================
+ Hits 503 508 +5
Misses 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The caller may want to forcibly reset a Khepri node without a clean unclustering, leaving other nodes connected and thinking they are still connected to the reset node.
This is the case of RabbitMQ with it "force reset" command.
How
This application environment variable allows it to prever the repair mechanism to revert that reset and put the reset node back into the cluster.