-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parent/child relationship in Opentelemetry spans #1779
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from otel semconv perspective!
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Does it make more sense to remove the TracingLinkType enum, and just have a bool UsePublisherAsParent? |
LGTM :) |
Proposed Changes
Adds an option to set remote span as parent rather than link when propagating Opentelemetry context between the publisher and receiver.
See issue #1666
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments