Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rabbitmq-upgrade revive: handle more errors (backport #12014) (backport #12015) #12016

Merged
merged 1 commit into from
Aug 15, 2024
Merged

rabbitmq-upgrade revive: handle more errors (backport #12014) (backport #12015) #12016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions deps/rabbit/src/rabbit_maintenance.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,14 +337,18 @@ revive_local_quorum_queue_replicas() ->
%% start local QQ replica (Ra server) of this queue
{Prefix, _Node} = amqqueue:get_pid(Q),
RaServer = {Prefix, node()},
rabbit_log:debug("Will start Ra server ~tp", [RaServer]),
rabbit_log:debug("Will start quorum queue replica (Ra server) ~tp", [RaServer]),
case rabbit_quorum_queue:restart_server(RaServer) of
ok ->
rabbit_log:debug("Successfully restarted Ra server ~tp", [RaServer]);
rabbit_log:debug("Successfully restarted a quorum queue replica ~tp", [RaServer]);
{error, {already_started, _Pid}} ->
rabbit_log:debug("Ra server ~tp is already running", [RaServer]);
rabbit_log:debug("Quorum queue replica ~tp is already running", [RaServer]);
{error, nodedown} ->
rabbit_log:error("Failed to restart Ra server ~tp: target node was reported as down")
rabbit_log:error("Failed to restart quorum queue replica ~tp: target node was reported as down", [RaServer]);
{error, name_not_registered} ->
rabbit_log:error("Failed to restart quorum queue replica ~tp: it reported as not registered (was deleted very recently?)", [RaServer]);
{error, Other} ->
rabbit_log:error("Failed to restart quorum queue replica ~tp: ~tp", [RaServer, Other])
end
end || Q <- Queues],
rabbit_log:info("Restart of local quorum queue replicas is complete").
Expand Down
Loading