Handle queue declaration failures in Khepri minority (backport #11980) (backport #12019) #12020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This fixes a case-clause crash in the logs in `cluster_minority_SUITE`.
When the database is not available `rabbit_amqqueue:declare/6,7` should
return a `protocol_error` record with an error message rather than a
hard crash. Also included in this change is the necessary changes to
typespecs: `rabbit_db_queue:create_or_get/1` is the first function to
return a possible `{error,timeout}`. That bubbles up through
`rabbit_amqqueue:internal_declare/3` and must be handled in each
`rabbit_queue_type:declare/2` callback.
(cherry picked from commit 8889d40)
(cherry picked from commit 1d0e840)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case-clause crash in the logs in
cluster_minority_SUITE. When the database is not availablerabbit_amqqueue:declare/6,7should return aprotocol_errorrecord with an error message rather than a hard crash. Also included in this change is the necessary changes to typespecs:rabbit_db_queue:create_or_get/1is the first function to return a possible{error,timeout}. That bubbles up throughrabbit_amqqueue:internal_declare/3and must be handled in eachrabbit_queue_type:declare/2callback.This is an automatic backport of pull request #11980 done by Mergify.
This is an automatic backport of pull request #12019 done by Mergify.