By @ayanda-D: make sure (non-replicated) CQs (classic queues) emit leader and members metrics, just like replicated QQs #12437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #12422 by @Ayanda-D with a different title and a slightly different explanation from me.
This change may seem controversial at first given the removal of classic queue mirroring starting with 4.0 but this is just a matter of unifying metric keys between non-replicated CQs and replicated QQs.
So with this change, CQs will report a leader and a list of members (of one node, just the leader) as stats keys. For
v4.0.x
, this seems perfectly fine.In fact, this will help improve https://github.com/rabbitmq/rabbitmqadmin-ng with its stricter JSON deserializer (compared to the original Python script).