Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rabbit_feature_flags: Lock registry once and enable many feature flags #12441

Merged
merged 2 commits into from
Oct 3, 2024
Merged

rabbit_feature_flags: Lock registry once and enable many feature flags #12441

merged 2 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. rabbit_feature_flags: Lock registry once and enable many feature flags 

    [Why]
Before this change, the controller was looping on all feature flags to
enable, then for each:
1. it checked if it was supported
2. it acquired the registry lock
3. it enabled the feature flag
4. it released the registry lock

It was done this way to not acquire the log if the feature flag was
unsupported in the first place.

However, this put more load on the lock mechanism.

[How]
This commit changes the order. The controller acquires the registry lock
once, then loops on feature flags to enable. The support check is now
under the registry lock.
    @dumbbell
    dumbbell committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2f67d19 View commit details
    Browse the repository at this point in the history

  2. rabbit_feature_flags: Fix copyright year 

    The subsystem didn't exist before 2019. The deprecated features support
was added in 2023.
    @dumbbell
    dumbbell committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e4abbfd View commit details
    Browse the repository at this point in the history