rabbit_feature_flags: Introduce hard vs. soft required feature flags #12466
+301
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
3 times, most recently
from
558e99e
to
2acffca
Compare
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
4 times, most recently
from
92379b4
to
cd88a14
Compare
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
from
cd88a14
to
18729d3
Compare
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
from
18729d3
to
eef3862
Compare
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
2 times, most recently
from
6fb7c50
to
28d511b
Compare
dumbbell
changed the title
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
from
28d511b
to
b29fb1f
Compare
|
The |
[Why]
Before this patch, required feature flags were basically checked during
boot: they must have been enabled when they were mere stable feature
flags. If they were not, the node refused to boot.
This was easy for the developer because making a feature flag required
allowed to remove the entire compatibility code. Very satisfying.
Unfortunately, this was a pain point to end users, especially those who
did not pay attention to RabbitMQ and the release notes and were just
asking their package manager to update everything. They could end up
with a node that refuse to boot. The only solution was to downgrade,
enable the disabled stable feature flags, upgrade again.
[How]
This patch introduces two levels of requirement to required feature
flags:
* `hard`: this corresponds to the existing behavior where a node will
refuse to boot if a hard required feature flag is not enabled before
the upgrade.
* `soft`: such a required feature flag will be automatically enabled
during the upgrade to a version where it is marked as required.
The level of requirement is set in the feature flag definition:
-rabbit_feature_flag(
{my_feature_flag,
#{stability => required,
require_level => hard
}}).
The default requirement level is `soft`. All existing required feature
flags have now a requirement level of `hard`.
The handling of soft required feature flag is done when the cluster
feature flags states are verified and synchronized. If a required
feature flag is not enabled yet, it is enabled at that time.
This means that as developers, we will have to keep compatibility code
forever for every soft required feature flag, like the feature flag
definition itself.
[Why] `failed_to_initialize_feature_flags_registry` was a little too vague.
dumbbell
force-pushed
the
enable-required-feature-flags-during-sync
branch
from
b29fb1f
to
de1d076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Before this patch, required feature flags were basically checked during boot: they must have been enabled when they were mere stable feature flags. If they were not, the node refused to boot.
This was easy for the developer because making a feature flag required allowed to remove the entire compatibility code. Very satisfying.
Unfortunately, this was a pain point to end users, especially those who did not pay attention to RabbitMQ and the release notes and were just asking their package manager to update everything. They could end up with a node that refuse to boot. The only solution was to downgrade, enable the disabled stabte feature flags, upgrade again.
How
This patch introduces two levels of requirement to required feature flags:
hard: this corresponds to the existing behavior where a node will refuse to boot if a hard required feature flag is not enabled before the upgrade.soft: such a required feature flag will be automatically enabled during the upgrade to a version where it is marked as required.The level of requirement is set in the feature flag definition:
The default requirement level is
soft. All existing required feature flags have now a requirement level ofhard.The handling of soft required feature flag is done when the cluster feature flags states are verified and synchronized. If a required feature flag is not enabled yet, it is enabled at that time.
This means that as developers, we will have to keep compatibility code forever for every soft required feature flag, like the feature flag definition itself.