By @Ayanda-D: stop QQ replicas when a QQ is forced to shrink to a single replica

.github/DISCUSSION_TEMPLATE/questions.yml

@@ -72,39 +72,74 @@ body:
     id: diagnostics_status
     attributes:
       label: rabbitmq-diagnostics status output
-      value: See https://www.rabbitmq.com/docs/cli to learn how to use rabbitmq-diagnostics
+      value: |
+        See https://www.rabbitmq.com/docs/cli to learn how to use rabbitmq-diagnostics
+        <details>
+
+        ```
+        # PASTE OUTPUT HERE, BETWEEN BACKTICKS
+        ```
+        </details>
     validations:
       required: true
   - type: textarea
     id: rabbitmq_logs
     attributes:
       label: Logs from node 1 (with sensitive values edited out)
       description: Relevant RabbitMQ logs with sensitive values edited out
-      value: See https://www.rabbitmq.com/docs/logging to learn how to collect logs
+      value: |
+        See https://www.rabbitmq.com/docs/logging to learn how to collect logs
+        <details>
+
+        ```
+        # PASTE LOG HERE, BETWEEN BACKTICKS
+        ```
+        </details>
     validations:
       required: true
   - type: textarea
     id: logs_node_2
     attributes:
       label: Logs from node 2 (if applicable, with sensitive values edited out)
       description: Relevant RabbitMQ logs with sensitive values edited out
-      value: See https://www.rabbitmq.com/docs/logging to learn how to collect logs
+      value: |
+        See https://www.rabbitmq.com/docs/logging to learn how to collect logs
+        <details>
+
+        ```
+        # PASTE LOG HERE, BETWEEN BACKTICKS
+        ```
+        </details>
     validations:
       required: false
   - type: textarea
     id: logs_node_3
     attributes:
       label: Logs from node 3 (if applicable, with sensitive values edited out)
       description: Relevant RabbitMQ logs with sensitive values edited out
-      value: See https://www.rabbitmq.com/docs/logging to learn how to collect logs
+      value: |
+        See https://www.rabbitmq.com/docs/logging to learn how to collect logs
+        <details>
+
+        ```
+        # PASTE LOG HERE, BETWEEN BACKTICKS
+        ```
+        </details>
     validations:
       required: false
   - type: textarea
     id: rabbitmq_conf
     attributes:
       label: rabbitmq.conf
       description: rabbitmq.conf contents
-      value: See https://www.rabbitmq.com/docs/configure#config-location to learn how to find rabbitmq.conf file location
+      value: |
+        See https://www.rabbitmq.com/docs/configure#config-location to learn how to find rabbitmq.conf file location
+        <details>
+
+        ```
+        # PASTE rabbitmq.conf HERE, BETWEEN BACKTICKS
+        ```
+        </details>
     validations:
       required: true
   - type: textarea
@@ -126,7 +161,14 @@ body:
     attributes:
       label: advanced.config
       description: advanced.config contents (if applicable)
-      value: See https://www.rabbitmq.com/docs/configure#config-location to learn how to find advanced.config file location
+      value: |
+        See https://www.rabbitmq.com/docs/configure#config-location to learn how to find advanced.config file location
+        <details>
+
+        ```
+        # PASTE advanced.config HERE, BETWEEN BACKTICKS
+        ```
+        </details>
     validations:
       required: false
   - type: textarea
@@ -135,9 +177,12 @@ body:
       label: Application code
       description: Relevant messaging-related parts of application code
       value: |
+        <details>
+
         ```python
-        # relevant messaging-related parts of your code go here
+        # PASTE CODE HERE, BETWEEN BACKTICKS
         ```
+        </details>
     validations:
       required: false
   - type: textarea
@@ -146,8 +191,12 @@ body:
       label: Kubernetes deployment file
       description: Kubernetes deployment YAML that demonstrates how RabbitMQ is deployed (if applicable)
       value: |
+        <details>
+
         ```yaml
         # Relevant parts of K8S deployment that demonstrate how RabbitMQ is deployed
+        # PASTE YAML HERE, BETWEEN BACKTICKS
         ```
+        </details>
     validations:
-      required: false
+      required: false

.github/workflows/oci-arm64-make.yaml

@@ -45,7 +45,7 @@ jobs:
       - name: make package-generic-unix
         if: steps.authorized.outputs.authorized == 'true'
         run: |
-          make package-generic-unix PROJECT_VERSION=4.0.0
+          make package-generic-unix PROJECT_VERSION=4.1.0-alpha.1
       - name: Upload package-generic-unix
         if: steps.authorized.outputs.authorized == 'true'
         uses: actions/upload-artifact@v4.3.1

.github/workflows/oci-make.yaml

@@ -38,7 +38,7 @@ jobs:
       - name: make package-generic-unix
         if: steps.authorized.outputs.authorized == 'true'
         run: |
-          make package-generic-unix PROJECT_VERSION=4.0.0
+          make package-generic-unix PROJECT_VERSION=4.1.0-alpha.1
       - name: Upload package-generic-unix
         if: steps.authorized.outputs.authorized == 'true'
         uses: actions/upload-artifact@v4.3.1

.github/workflows/rabbitmq_peer_discovery_aws.yaml

@@ -66,7 +66,7 @@ jobs:
         ecs-cli --version
     - name: AUTHENTICATE TO GOOGLE CLOUD
       if: steps.authorized.outputs.authorized == 'true'
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: CONFIGURE BAZEL

.github/workflows/templates/test-mixed-versions.template.yaml

@@ -96,7 +96,7 @@ jobs:
           https://builds.hex.pm
           https://cdn.jsdelivr.net/hex
     - name: AUTHENTICATE TO GOOGLE CLOUD
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: BUILD SECONDARY UMBRELLA ARCHIVE

.github/workflows/templates/test.template.yaml

@@ -73,7 +73,7 @@ jobs:
       run: |
         echo "value=bazel-repo-cache-${{ hashFiles('MODULE.bazel') }}" | tee -a $GITHUB_OUTPUT
     - name: AUTHENTICATE TO GOOGLE CLOUD
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: REPO CACHE

.github/workflows/test-authnz.yaml

@@ -58,7 +58,7 @@ jobs:
           https://cdn.jsdelivr.net/hex
 
     - name: Authenticate To Google Cloud
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
 

.github/workflows/test-management-ui-for-pr.yaml

@@ -38,7 +38,7 @@ jobs:
           https://cdn.jsdelivr.net/hex
 
     - name: Authenticate To Google Cloud
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
 

.github/workflows/test-management-ui.yaml

@@ -52,7 +52,7 @@ jobs:
           https://cdn.jsdelivr.net/hex
 
     - name: Authenticate To Google Cloud
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
 

.github/workflows/test-mixed-versions.yaml

@@ -74,7 +74,7 @@ jobs:
           https://builds.hex.pm
           https://cdn.jsdelivr.net/hex
     - name: AUTHENTICATE TO GOOGLE CLOUD
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: BUILD SECONDARY UMBRELLA ARCHIVE

.github/workflows/test-plugin-mixed.yaml

@@ -51,7 +51,7 @@ jobs:
           https://builds.hex.pm
           https://cdn.jsdelivr.net/hex
     - name: AUTHENTICATE TO GOOGLE CLOUD
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: CONFIGURE BAZEL

.github/workflows/test-plugin.yaml

@@ -51,7 +51,7 @@ jobs:
           https://builds.hex.pm
           https://cdn.jsdelivr.net/hex
     - name: AUTHENTICATE TO GOOGLE CLOUD
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: CONFIGURE BAZEL

.github/workflows/test.yaml

@@ -51,7 +51,7 @@ jobs:
       run: |
         echo "value=bazel-repo-cache-${{ hashFiles('MODULE.bazel') }}" | tee -a $GITHUB_OUTPUT
     - name: AUTHENTICATE TO GOOGLE CLOUD
-      uses: google-github-actions/auth@v2.1.5
+      uses: google-github-actions/auth@v2.1.6
       with:
         credentials_json: ${{ secrets.REMOTE_CACHE_CREDENTIALS_JSON }}
     - name: REPO CACHE

deps/amqp10_client/src/amqp10_client_session.erl

@@ -737,15 +737,13 @@ translate_terminus_durability(configuration) -> 1;
 translate_terminus_durability(unsettled_state) -> 2.
 
 translate_filters(Filters)
-  when is_map(Filters) andalso
-       map_size(Filters) == 0 ->
+  when map_size(Filters) =:= 0 ->
     undefined;
-translate_filters(Filters)
-  when is_map(Filters) ->
+translate_filters(Filters) ->
     {map,
      maps:fold(
        fun
-          (<<"apache.org:legacy-amqp-headers-binding:map">> = K, V, Acc) when is_map(V) ->
+           (<<"apache.org:legacy-amqp-headers-binding:map">> = K, V, Acc) when is_map(V) ->
                %% special case conversion
                Key = sym(K),
                [{Key, {described, Key, translate_legacy_amqp_headers_binding(V)}} | Acc];

deps/amqp10_client/src/amqp10_msg.erl

@@ -433,7 +433,10 @@ wrap_ap_value(V) when is_integer(V) ->
     case V < 0 of
         true -> {int, V};
         false -> {uint, V}
-    end.
+    end;
+wrap_ap_value(V) when is_number(V) ->
+    %% AMQP double and Erlang float are both 64-bit.
+    {double, V}.
 
 %% LOCAL
 header_value(durable, undefined) -> false;

deps/amqp10_common/app.bzl

@@ -72,7 +72,7 @@ def all_srcs(name = "all_srcs"):
     )
     filegroup(
         name = "public_hdrs",
-        srcs = ["include/amqp10_framing.hrl", "include/amqp10_types.hrl"],
+        srcs = ["include/amqp10_filtex.hrl", "include/amqp10_framing.hrl", "include/amqp10_types.hrl"],
     )
     filegroup(
         name = "private_hdrs",

deps/amqp10_common/include/amqp10_filtex.hrl

@@ -0,0 +1,15 @@
+%% This Source Code Form is subject to the terms of the Mozilla Public
+%% License, v. 2.0. If a copy of the MPL was not distributed with this
+%% file, You can obtain one at https://mozilla.org/MPL/2.0/.
+%%
+%% Copyright (c) 2007-2024 Broadcom. All Rights Reserved. The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. All rights reserved.
+
+
+%% AMQP Filter Expressions Version 1.0 Working Draft 09
+%% https://groups.oasis-open.org/higherlogic/ws/public/document?document_id=66227
+
+-define(DESCRIPTOR_NAME_PROPERTIES_FILTER, <<"amqp:properties-filter">>).
+-define(DESCRIPTOR_CODE_PROPERTIES_FILTER, 16#173).
+
+-define(DESCRIPTOR_NAME_APPLICATION_PROPERTIES_FILTER, <<"amqp:application-properties-filter">>).
+-define(DESCRIPTOR_CODE_APPLICATION_PROPERTIES_FILTER, 16#174).

deps/rabbit/BUILD.bazel

@@ -1207,6 +1207,7 @@ rabbitmq_integration_suite(
     name = "amqp_client_SUITE",
     size = "large",
     additional_beam = [
+        ":test_amqp_utils_beam",
         ":test_event_recorder_beam",
     ],
     shard_count = 3,
@@ -1215,6 +1216,16 @@ rabbitmq_integration_suite(
     ],
 )
 
+rabbitmq_integration_suite(
+    name = "amqp_filtex_SUITE",
+    additional_beam = [
+        ":test_amqp_utils_beam",
+    ],
+    runtime_deps = [
+        "//deps/rabbitmq_amqp_client:erlang_app",
+    ],
+)
+
 rabbitmq_integration_suite(
     name = "amqp_proxy_protocol_SUITE",
     size = "medium",
@@ -1235,6 +1246,7 @@ rabbitmq_integration_suite(
 rabbitmq_integration_suite(
     name = "amqp_auth_SUITE",
     additional_beam = [
+        ":test_amqp_utils_beam",
         ":test_event_recorder_beam",
     ],
     shard_count = 2,
@@ -1246,6 +1258,9 @@ rabbitmq_integration_suite(
 rabbitmq_integration_suite(
     name = "amqp_address_SUITE",
     shard_count = 2,
+    additional_beam = [
+        ":test_amqp_utils_beam",
+    ],
     runtime_deps = [
         "//deps/rabbitmq_amqp_client:erlang_app",
     ],
@@ -1358,6 +1373,7 @@ eunit(
         ":test_clustering_utils_beam",
         ":test_event_recorder_beam",
         ":test_rabbit_ct_hook_beam",
+        ":test_amqp_utils_beam",
     ],
     target = ":test_erlang_app",
     test_env = {

deps/rabbit/Makefile

@@ -239,16 +239,26 @@ define ct_master.erl
 	peer:call(Pid2, persistent_term, put, [rabbit_ct_tcp_port_base, 25000]),
 	peer:call(Pid3, persistent_term, put, [rabbit_ct_tcp_port_base, 27000]),
 	peer:call(Pid4, persistent_term, put, [rabbit_ct_tcp_port_base, 29000]),
-	ct_master:run("$1"),
+	ct_master_fork:run("$1"),
+	Fail1 = peer:call(Pid1, cth_parallel_ct_detect_failure, has_failures, []),
+	Fail2 = peer:call(Pid2, cth_parallel_ct_detect_failure, has_failures, []),
+	Fail3 = peer:call(Pid3, cth_parallel_ct_detect_failure, has_failures, []),
+	Fail4 = peer:call(Pid4, cth_parallel_ct_detect_failure, has_failures, []),
 	peer:stop(Pid4),
 	peer:stop(Pid3),
 	peer:stop(Pid2),
 	peer:stop(Pid1),
-	halt()
+	if
+		Fail1 -> halt(1);
+		Fail2 -> halt(2);
+		Fail3 -> halt(3);
+		Fail4 -> halt(4);
+		true -> halt(0)
+	end
 endef
 
 PARALLEL_CT_SET_1_A = amqp_client unit_cluster_formation_locking_mocks unit_cluster_formation_sort_nodes unit_collections unit_config_value_encryption unit_connection_tracking
-PARALLEL_CT_SET_1_B = amqp_address amqp_auth amqp_credit_api_v2 amqp_system signal_handling single_active_consumer unit_access_control_authn_authz_context_propagation unit_access_control_credential_validation unit_amqp091_content_framing unit_amqp091_server_properties unit_app_management
+PARALLEL_CT_SET_1_B = amqp_address amqp_auth amqp_credit_api_v2 amqp_filtex amqp_system signal_handling single_active_consumer unit_access_control_authn_authz_context_propagation unit_access_control_credential_validation unit_amqp091_content_framing unit_amqp091_server_properties unit_app_management
 PARALLEL_CT_SET_1_C = amqp_proxy_protocol amqpl_consumer_ack amqpl_direct_reply_to backing_queue bindings rabbit_db_maintenance rabbit_db_msup rabbit_db_policy rabbit_db_queue rabbit_db_topic_exchange rabbit_direct_reply_to_prop cluster_limit cluster_minority term_to_binary_compat_prop topic_permission transactions unicode unit_access_control
 PARALLEL_CT_SET_1_D = amqqueue_backward_compatibility channel_interceptor channel_operation_timeout classic_queue classic_queue_prop config_schema peer_discovery_dns peer_discovery_tmp_hidden_node per_node_limit per_user_connection_channel_limit