4.1/main: Make CI: Fix and enhance ct_master #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-ct-master-patching
branch
from
861e716
to
2a0db91
Compare
The ct_run:run_test function already takes care of the node's logs. The ct_master_logs module takes care of ct_master itself.
Needed to file:set_cwd like in normal CT.
It makes more sense to sort by node name, than to have the results in the order they finished.
Instead of having a CT hook just to know whether our tests failed.
Of a ct_master run. This uses the builtin CT Master event handler to gather the results.
lhoguin
force-pushed
the
loic-ct-master-patching
branch
from
36af0a1
to
4127f15
Compare
|
This is ready to be merged. I will send OTP pull requests later this week. One interesting thing this PR does is print a list of failed cases at the end of the CT master output:
Note that this prints all errors but that |
lhoguin
changed the title
|
Opened erlang/otp#8946 to backport this to OTP. |
lhoguin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this will be sent as a PR to OTP.