Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT, x.509 certificate-based authentication: use the correct key name for the TLS SAN type configuration parameter #12604

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Oct 29, 2024

Proposed Changes

It fixes an issue caused when the mqtt.ssl_cert_client_id_san_type was renamed in the schema to 'mqtt.ssl_cert_login_san_type` to keep it consistent with how the username is determined. But one part of the code was not updated accordingly.

Adding a selenium end-2-end test so that this kind of issues are spotted earlier.

References #12595.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Cannot set mqtt.ssl_cert_client_id_san_type and san_index #12595)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Oct 29, 2024
@mergify mergify bot added the bazel label Oct 29, 2024
@michaelklishin michaelklishin changed the title Use the correct variable name for TLS SAN type MQTT, x.509 certificate-based authentication: use the correct key name for the TLS SAN type configuration parameter Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants