Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 9043 #9045

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Fix 9043 #9045

merged 7 commits into from
Aug 10, 2023

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Aug 10, 2023 •
edited by michaelklishin
Loading

Proposed Changes

Fixes #9043

Issue found when using cache+http too.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales changed the base branch from main to v3.11.x August 10, 2023 11:55
@MarcialRosales
Fix issue by removing the attribute rabbit_auth_backend_http
5e6c043 
which is injected by some messaging protocols such as amqp 1.0
to preverse the credentails after the initial login phase has
been completed
@MarcialRosales
Handle functions as possible values
da07c3e 
in rabbit_http_util:quote_plus function
@MarcialRosales
Exclude any attribute whose value is a function
43888d5
@MarcialRosales
Fix integration tests
8f16a60
@MarcialRosales
Unnecessary
46d605f
@MarcialRosales MarcialRosales marked this pull request as ready for review August 10, 2023 17:08
@michaelklishin michaelklishin merged commit d63e1fe into v3.11.x Aug 10, 2023
15 checks passed
@michaelklishin michaelklishin deleted the fix-9043 branch August 10, 2023 18:49
@michaelklishin michaelklishin mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken Awaiting requested review from lukebakken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcialRosales @michaelklishin