4 cors issues #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds configurable CORS (Cross-Origin Resource Sharing) support to the cell service API, allowing administrators to control which origins can access the endpoints via the CORS_ORIGINS environment variable.
Key changes:
- Introduced
CORS_ORIGINSenvironment variable for comma-separated allowed origins list (defaults to allow all origins) - Implemented
cors_filterfunction in the server module to handle CORS configuration - Applied CORS filter to all API routes including health check and cell query endpoints
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/config.rs | Added cors_origins field to Config struct with parsing logic to split and trim comma-separated origins from environment variable |
| src/utils/server.rs | Implemented cors_filter function with GET and OPTIONS methods support, and integrated CORS filter into route configuration |
| README.md | Added documentation for the new CORS_ORIGINS environment variable with example usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
Contributor
Co-authored-by: karlTGA <12493530+karlTGA@users.noreply.github.com>
[WIP] Fix CORS issues and service authorization necessity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds configurable Cross-Origin Resource Sharing (CORS) support to the service, allowing you to restrict which origins can access the API based on an environment variable. The main changes include updating configuration handling, introducing a new CORS filter, and applying it to the server routes.
Configuration and environment variable support:
CORS_ORIGINSenvironment variable to the documentation and theConfigstruct, allowing a comma-separated list of allowed origins to be specified. If not set, all origins are allowed. [1] [2] [3]CORS implementation in the server:
cors_filterfunction that builds a CORS filter using the configured origins and applies it to all routes. If no origins are specified, any origin is allowed. [1] [2]