Fix reset! when using namespaced cache store #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santib
force-pushed
the
fix-cache-with-namespace
branch
2 times, most recently
from
cf62482 to
74517c3
Compare
santib
force-pushed
the
fix-cache-with-namespace
branch
from
8a150d1 to
c939eda
Compare
santib
force-pushed
the
fix-cache-with-namespace
branch
from
c939eda to
6405834
Compare
grzuy
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #672
Sending a regex doesn't work with some cache stores (e.g.
ActiveSupport::Cache::RedisCacheStore).Seems like some cache stores need it to be a regex, and some others need it to be a string. This inconsistency lives in Rails itself. Maybe it's required to unify the API provided by Rails.
Another option would be making use of our proxies to handle this difference.