Better error management in REST API draw endpoint #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of failing with None argument for cairo.Context(), raise RacksDBDrawingError as soon as unsupported output image format is detected.
Return HTTP/400 error when draw endpoint is requested with unsupported image format.
Return HTTP/400 error when draw endpoint is called with unsupported entity.
Update HTTP/400 error description on REST API draw endpoint to mention new cases it can be returned.
Update HTTP/400 error description on draw endpoint.
rezib
force-pushed
the
pr/fix-api-draw
branch
from
fb0f840 to
2a4e854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.