MAPS-748 autocomplete sessions into javascript sdk #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boonboonsiri
commented
Dec 13, 2023
src/ui/autocomplete.ts
Outdated
| } | ||
|
|
||
| public generateUUID = (): string => { | ||
| return crypto.randomUUID(); |
Contributor
Author
There was a problem hiding this comment.
I wanted to use crypto.randomUUID() but not sure if this is the case but maybe:
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+552
to
+556
| const uuid = 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, (char) => { | ||
| const r = Math.random() * 16 | 0; | ||
| const v = (char == 'x') ? r : (r & 0x3 | 0x8); | ||
| return v.toString(16); | ||
| }); |
Check failure
Code scanning / CodeQL
Insecure randomness
boonboonsiri
commented
Dec 13, 2023
|
|
||
| // Radar Autocomplete Session | ||
| if (this.session) { | ||
| const userId = Storage.getItem(Storage.USER_ID) || undefined; |
Contributor
Author
There was a problem hiding this comment.
Right now I'm still including these even though right now we don't use them, but in case we wanted to store them in the future so we don't have to update the sdk twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding autocomplete sessions in Radar's JavaScript SDK
Demo:
https://frontend-git-boon-radar-autocomplete-demo-radarlabs.vercel.app/dashboard/maps/maps-explorer/autocomplete?live=true&project=63bd823ce0e5fb0060b7cb49