Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide map for items without geometry #564

Closed

Conversation

vprivat-ads
Copy link
Contributor

This makes little sense to display an empty map for items without geometry, so this PR hides the map in this case.

@vprivat-ads vprivat-ads requested a review from m-mohr as a code owner February 6, 2025 11:37
@m-mohr
Copy link
Collaborator

m-mohr commented Feb 6, 2025

Thanks, but this may lead to issues as you can't show assets or other data on the map any longer. Even though there's no geometry, there could still be data to show. This would need to show the map again once interactions with assets (e.g. Show on Map button) are happening.
This will be somewhat tackled by #535 already, too, and we should focus effort on this PR to improve it in the long run. Thus closing in favor of #535.

@m-mohr m-mohr closed this Feb 6, 2025
@vprivat-ads
Copy link
Contributor Author

Ah yes thanks, I didn't see it was also addressing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants