Recommend HTTP(S) for thumbnails etc. #1329
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
force-pushed
the
thumbnails-http
branch
from
d47901a to
9f57300
Compare
|
It is a bit weird that the default asset is mixed now in one of my cases (default: S3, alternate: HTTP for all data except for thumbnails where it's the other way around), but I think that's justified because tooling should be able to read thumbnails easily via HTTP, right? @gadomski |
I think so. I almost wonder if we should lean into the "special" assets (e.g. thumbnails) harder in the documentation so folks know (a) to include them and (b) to set up the hrefs differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): None
Proposed Changes:
PR Checklist:
or a CHANGELOG entry is not required.
and I have opened issue/PR #XXX to track the change.