Conversation
Closed
✅ Deploy Preview for hydraflow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jokroese
requested changes
Nov 22, 2025
Member
jokroese
left a comment
jokroese
left a comment
There was a problem hiding this comment.
There are two main bits here that I'd like to deal with first.
- the runtime state leaking into the IR, through the
stateonIRNodeandNodeDefinition. We should keep node states out of the IR, and inHydraEngine. - the side effects inside graph evaluation.
validateGraphandexecuteGraphnow do async work. But they should stay pure(ish): graph -> chain/issues. And camera initialisation should be insideHydraEngine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bunch of TODOs to clean it up
partially closes #45