-
Notifications
You must be signed in to change notification settings - Fork 0
Sinthavong1337/eng 254 implement a settings page for user preferences and tag #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sinthavong1337/eng 254 implement a settings page for user preferences and tag #168
Conversation
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
… image Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
Co-authored-by: imsengdao <imsengdao@gmail.com>
…tag editing UX, and improve destructive action layout
…n Edit Tag dialog
|
Pull Request Smart Comments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements a comprehensive settings page for user preferences and tag management functionality. The changes introduce a new settings interface that includes appearance controls (theme selection) and a complete tag management system with CRUD operations.
- Adds a new settings page with theme selection and tag management capabilities
- Implements full CRUD operations for tags in the client library
- Creates a dedicated TagManager component with create/edit/delete functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| next/src/lib/client.ts | Extends useTags hook with CRUD operations for tag management |
| next/src/components/ui/theme-toggle.tsx | Adds ThemeSelector component for theme preference selection |
| next/src/components/TagManager.tsx | New component providing comprehensive tag management UI |
| next/src/components/OutfitSuggestions.tsx | Updates Tag component usage with compact prop |
| next/src/components/AuthenticatedHeader.tsx | Replaces theme toggle with settings navigation link |
| next/src/app/(authenticated)/settings/page.tsx | New settings page with appearance and tag management sections |
| next/next.config.mjs | Adds Clerk image domain to remote patterns for user avatars |
| hono/package.json | Updates @hono/clerk-auth dependency version |
Files not reviewed (1)
- hono/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
next/src/components/TagManager.tsx:276
- The color selection buttons should include keyboard navigation support. Consider adding
onKeyDownhandlers for Enter and Space keys to improve accessibility.
/>
No description provided.