Cuttlefish - Release Candidate 1

[dhedey]

Summary

Finishes various changes for Cuttlefish rc-1, notably:

• Updates Scrypto to cuttlefish-423e26ab
  • This pulls in updates to canonical manifest display and error rendering
• Adds an index from finalized subintent hash => state version to allow adding a subintent status endpoint in the future.
• Core API changes:
  • Preview V2 validation error is filled in
  • Some type renames, notably AccessRuleNode => CompositeRequirement and ProofRule => BasicRequirement, in keeping with the updates in the engine, in docs, and across the stack. (This was also done in the Engine State API)
  • Added some new fields for tip_proportion in various responses. All are marked as optional so that a Cuttlefish client could talk to a Bottlenose node without error.
  • A couple of well known addresses. All are marked as optional so that a Cuttlefish client could talk to a Bottlenose node without error.
  • TransactionValidationConfigurationSubstate is properly typed
• A few updates of key dependencies in Java
• Mainnet configuration generated with sensible values:

        ProtocolVersionName::cuttlefish() => EnactAtStartOfEpochIfValidatorsReady {
            // =================================================================
            // PROTOCOL_VERSION: "cuttlefish"
            // READINESS_SIGNAL: "96e00440adafe5e2000000cuttlefish"
            // =================================================================
            // The below estimates are based off:
            // - Calculating relative to epoch 150729
            // - Using that epoch 150729 started at 2024-11-13T01:18:58.703Z
            // - Assuming epoch length will be 5 mins
            // =================================================================
            lower_bound_inclusive: Epoch::of(158682), // estimated: 2024-12-10T16:03:58.703Z
            upper_bound_exclusive: Epoch::of(161562), // estimated: 2024-12-20T16:03:58.703Z
            readiness_thresholds: vec![
                SignalledReadinessThreshold {
                    required_ratio_of_stake_supported: dec!(0.75),
                    required_consecutive_completed_epochs_of_support: 4032, // estimated: 2 weeks
                },
            ],
        },

This is not completely done yet, there is a little left for Yulong tomorrow as part of the release preparation process:

• Updating the API doc versions and regenerating
• Updating the docker image build versions
• etc etc

[github-actions]

Phylum Report Link

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 8.47458% with 324 lines in your changes missing coverage. Please review.

Project coverage is 42.4%. Comparing base (5c2aa29) to head (763e2ff).

Files with missing lines	Patch %	Lines
...re_api/conversions/substates/boot_loader_module.rs	0.0%	71 Missing ⚠️
...e_api/conversions/substates/access_rules_module.rs	0.0%	23 Missing ⚠️
...r/src/engine_state_api/conversions/access_rules.rs	0.0%	23 Missing ⚠️
.../generated/models/transaction_validation_config.rs	0.0%	21 Missing ⚠️
core-rust/state-manager/src/receipt.rs	6.6%	14 Missing ⚠️
.../core_api/generated/models/preparation_settings.rs	0.0%	11 Missing ⚠️
...pi/generated/models/manifest_validation_ruleset.rs	0.0%	9 Missing ⚠️
..._api/generated/models/message_validation_config.rs	0.0%	9 Missing ⚠️
core-rust/state-manager/src/jni/mempool.rs	0.0%	9 Missing ⚠️
core-rust/state-manager/src/store/rocks_db.rs	11.1%	8 Missing ⚠️
... and 56 more

Additional details and impacted files

@@             Coverage Diff             @@
##             develop   #1020     +/-   ##
===========================================
- Coverage       42.5%   42.4%   -0.2%     
- Complexity      4623    4625      +2     
===========================================
  Files           1775    1780      +5     
  Lines          54821   55035    +214     
  Branches        1524    1524             
===========================================
+ Hits           23314   23340     +26     
- Misses         31028   31216    +188     
  Partials         479     479             

Flag	Coverage Δ
rust	42.4% <8.4%> (-0.2%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ersions/substates/protocol_update_status_module.rs	0.0% <ø> (ø)
...erver/src/core_api/generated/models/access_rule.rs	0.0% <ø> (ø)
...src/core_api/generated/models/basic_requirement.rs	0.0% <ø> (ø)
...core_api/generated/models/composite_requirement.rs	0.0% <ø> (ø)
...erver/src/core_api/generated/models/entity_type.rs	0.0% <ø> (ø)
...ted/models/lts_transaction_submit_error_details.rs	0.0% <ø> (ø)
...erver/src/core_api/generated/models/requirement.rs	0.0% <ø> (ø)
...i-server/src/core_api/generated/models/substate.rs	0.0% <ø> (ø)
...c/core_api/generated/models/transaction_receipt.rs	0.0% <ø> (ø)
...nerated/models/transaction_submit_error_details.rs	0.0% <ø> (ø)
... and 78 more

... and 2 files with indirect coverage changes

[github-actions]

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1020
docker.io/radixdlt/private-babylon-node:b733423be7
docker.io/radixdlt/private-babylon-node:sha-b733423

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud