Skip to content

MeshAPI - support non-user transactions #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 15, 2024

Conversation

lrubasze
Copy link
Contributor

@lrubasze lrubasze commented Nov 13, 2024

  • support non-user transactions when calculating balance changes
  • share fee payment calculator between Core and Mesh APIs
  • Warnings cleanup
  • mesh-cli configs tweaked

Copy link

Phylum Report Link

@lrubasze lrubasze force-pushed the feature/mesh-api-block-part-2 branch from 545d947 to efc0360 Compare November 13, 2024 13:47
Copy link

github-actions bot commented Nov 13, 2024

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1024
docker.io/radixdlt/private-babylon-node:10898e6c08
docker.io/radixdlt/private-babylon-node:sha-10898e6

@lrubasze lrubasze force-pushed the feature/mesh-api-block-part-2 branch from efc0360 to 69e5992 Compare November 13, 2024 16:50
@iamyulong iamyulong force-pushed the feature/mesh-api-block-part-2 branch 2 times, most recently from 28e2d38 to 2a7ad25 Compare November 13, 2024 17:18
@iamyulong iamyulong force-pushed the feature/mesh-api-block-part-2 branch 2 times, most recently from 86c9f66 to b7fd739 Compare November 13, 2024 17:26
@iamyulong iamyulong force-pushed the feature/mesh-api-block-part-2 branch from b7fd739 to bc1e1e2 Compare November 13, 2024 17:28
@lrubasze lrubasze marked this pull request as ready for review November 14, 2024 13:24
@lrubasze lrubasze changed the title MeshAPI - Add fee support to operations MeshAPI - support non-user transactions Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 336 lines in your changes missing coverage. Please review.

Project coverage is 40.7%. Comparing base (b3b7d27) to head (0a563c5).

Files with missing lines Patch % Lines
core-rust/node-common/src/fee_computer.rs 0.0% 123 Missing ⚠️
...st/core-api-server/src/core_api/conversions/lts.rs 0.0% 72 Missing ⚠️
...mesh-api-server/src/mesh_api/conversions/common.rs 0.0% 68 Missing ⚠️
core-rust/node-common/src/numerics.rs 0.0% 44 Missing ⚠️
...ust/mesh-api-server/src/mesh_api/handlers/block.rs 0.0% 15 Missing ⚠️
...r/src/mesh_api/handlers/construction_preprocess.rs 0.0% 7 Missing ⚠️
...ver/src/mesh_api/handlers/construction_payloads.rs 0.0% 5 Missing ⚠️
...server/src/mesh_api/handlers/construction_parse.rs 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             feature/mesh   #1024    +/-   ##
===============================================
  Coverage            40.6%   40.7%            
+ Complexity           4624    4623     -1     
===============================================
  Files                1886    1888     +2     
  Lines               57448   57344   -104     
  Branches             1527    1527            
===============================================
- Hits                23346   23345     -1     
+ Misses              33621   33516   -105     
- Partials              481     483     +2     
Flag Coverage Δ
rust 40.7% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re-api-server/src/core_api/conversions/numerics.rs 51.7% <ø> (+6.9%) ⬆️
...ore_api/conversions/substates/consensus_manager.rs 0.0% <ø> (ø)
...-api-server/src/mesh_api/conversions/addressing.rs 0.0% <ø> (ø)
...esh-api-server/src/mesh_api/conversions/context.rs 0.0% <ø> (ø)
...mesh-api-server/src/mesh_api/conversions/errors.rs 0.0% <ø> (ø)
...sh-api-server/src/mesh_api/conversions/numerics.rs 0.0% <ø> (ø)
core-rust/mesh-api-server/src/mesh_api/types.rs 0.0% <ø> (ø)
...server/src/mesh_api/handlers/construction_parse.rs 0.0% <0.0%> (ø)
...ver/src/mesh_api/handlers/construction_payloads.rs 0.0% <0.0%> (ø)
...r/src/mesh_api/handlers/construction_preprocess.rs 0.0% <0.0%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

@lrubasze lrubasze force-pushed the feature/mesh-api-block-part-2 branch from 604d969 to 0a563c5 Compare November 14, 2024 15:23
Copy link

@lrubasze lrubasze merged commit 5667cf9 into feature/mesh Nov 15, 2024
23 checks passed
@lrubasze lrubasze deleted the feature/mesh-api-block-part-2 branch November 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants