Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR to avoid branch pruning #1035

Draft
wants to merge 159 commits into
base: release/cuttlefish
Choose a base branch
from
Draft

Conversation

iamyulong
Copy link
Member

@iamyulong iamyulong commented Nov 28, 2024

This PR ensures the feature/mesh branch is not deleted by github, as it might be needed to release mesh support on top of a Cuttlefish node, instead of first being available at Dugong.

Summary

Tip

Start with the context of your PR. Why are you making this change? What does it address? Link back to an issue if relevant.

Then summarise the changes that were made. Bullet points are fine.

Details

Tip

This section is optional. Go into more detail about the changes that were made, or the thinking behind the changes.

Testing

Tip

Explain what testing / verification is done, including manual testing or automated testing.

Copy link

Phylum Report Link

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 4.64610% with 2627 lines in your changes missing coverage. Please review.

Project coverage is 40.7%. Comparing base (3eb74c0) to head (6cb8f0a).
Report is 3 commits behind head on release/cuttlefish.

Files with missing lines Patch % Lines
...-api-server/src/mesh_api/conversions/operations.rs 0.0% 223 Missing ⚠️
...pi-server/src/mesh_api/handlers/account_balance.rs 0.0% 141 Missing ⚠️
core-rust/node-common/src/fee_computer.rs 0.0% 123 Missing ⚠️
core-rust/mesh-api-server/src/mesh_api/errors.rs 0.0% 122 Missing ⚠️
.../mesh-api-server/src/mesh_api/conversions/block.rs 0.0% 112 Missing ⚠️
...ver/src/mesh_api/handlers/construction_payloads.rs 0.0% 107 Missing ⚠️
...-api-server/src/mesh_api/conversions/addressing.rs 13.1% 99 Missing ⚠️
core-rust/mesh-api-server/src/jni/mod.rs 0.0% 81 Missing ⚠️
core-rust/mesh-api-server/src/mesh_api/server.rs 0.0% 76 Missing ⚠️
...st/core-api-server/src/core_api/conversions/lts.rs 0.0% 72 Missing ⚠️
... and 105 more
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             release/cuttlefish   #1035     +/-   ##
======================================================
- Coverage                  42.4%   40.7%   -1.7%     
- Complexity                 4624    4627      +3     
======================================================
  Files                      1782    1892    +110     
  Lines                     55167   57683   +2516     
  Branches                   1524    1527      +3     
======================================================
+ Hits                      23406   23528    +122     
- Misses                    31282   33674   +2392     
- Partials                    479     481      +2     
Flag Coverage Δ
rust 40.7% <4.6%> (-1.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/main/java/com/radixdlt/sbor/NodeSborCodecs.java 99.2% <100.0%> (+<0.1%) ⬆️
...re-api-server/src/core_api/conversions/numerics.rs 51.7% <ø> (+6.9%) ⬆️
...ore_api/conversions/substates/consensus_manager.rs 0.0% <ø> (ø)
...esh-api-server/src/mesh_api/conversions/context.rs 100.0% <100.0%> (ø)
core-rust/state-manager/src/mempool/mod.rs 0.0% <ø> (ø)
...api-server/src/mesh_api/generated/models/amount.rs 87.5% <87.5%> (ø)
core-rust/state-manager/src/mempool/metrics.rs 76.1% <0.0%> (-1.3%) ⬇️
...re/src/main/java/com/radixdlt/RadixNodeModule.java 80.2% <83.3%> (+0.1%) ⬆️
.../com/radixdlt/environment/MeshApiServerConfig.java 50.0% <50.0%> (ø)
...va/com/radixdlt/monitoring/ApplicationVersion.java 85.1% <71.4%> (-6.2%) ⬇️
... and 110 more

... and 3 files with indirect coverage changes

Copy link

github-actions bot commented Nov 28, 2024

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1035
docker.io/radixdlt/private-babylon-node:f5bf4aba69
docker.io/radixdlt/private-babylon-node:sha-f5bf4ab

@iamyulong iamyulong changed the title Feature/mesh Draft PR to avoid branch pruning Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants