Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ephemeral benchmark tests on each PR #1042

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

les-sheppard
Copy link
Contributor

Updted github docker workflow, to run Node CI benchmark tests on each PR.

The tests are run by triggering a Jenkins job. When complete, the test harness will add a comment to the triggering PR, with the TPS stats and links to grafana dashboards.

Copy link

Phylum Report Link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.7%. Comparing base (2057ecf) to head (4ffd6b5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #1042     +/-   ##
===========================================
- Coverage       40.7%   40.7%   -0.1%     
+ Complexity      4630    4629      -1     
===========================================
  Files           1892    1892             
  Lines          57508   57508             
  Branches        1527    1527             
===========================================
- Hits           23417   23416      -1     
- Misses         33611   33612      +1     
  Partials         480     480             
Flag Coverage Δ
rust 40.7% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1042
docker.io/radixdlt/private-babylon-node:2976ea1283
docker.io/radixdlt/private-babylon-node:sha-2976ea1

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 14:54:27

Test case: xrd_transfer, TPS: 169
Test case: basic_swap, TPS: 136
Test case: radquest, TPS: 79


Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-12 15:48:06

Test case: xrd_transfer, TPS: 170
Test case: basic_swap, TPS: 139
Test case: radquest, TPS: 76

Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@les-sheppard les-sheppard marked this pull request as ready for review December 12, 2024 16:02
Copy link
Member

@iamyulong iamyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@les-sheppard les-sheppard merged commit 5a4f161 into develop Dec 13, 2024
25 checks passed
@les-sheppard les-sheppard deleted the pro-74-run-node-ci-benchmark-tests-on-pr branch December 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants