Merge pull request #1779 from radixdlt/feature/faster-ra-in-main

Improve Rust Analyzer's performance on the main branch

.github/actions/setup-env/action.yml

@@ -36,5 +36,4 @@ runs:
       # Switch to more recent LLVM/Clang 15.0.7
       # see: https://github.com/actions/runner-images/blob/macOS-12/20240105.3/images/macos/macos-12-Readme.md
       run: echo "$(brew --prefix llvm@15)/bin" >> $GITHUB_PATH
-      shell: bash
-
+      shell: bash

.github/workflows/bench.yml

@@ -11,7 +11,9 @@ concurrency:
 jobs:
   benchmark:
     name: Run bench
-    runs-on: gh-runner-scrypto-ubuntu-jammy-16-cores
+    runs-on: ubuntu-16-cores-selfhosted
+    permissions:
+      pull-requests: write
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment

.github/workflows/ci.yml

@@ -127,7 +127,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [gh-runner-scrypto-ubuntu-jammy-16-cores]
+        os: [ubuntu-16-cores-selfhosted]
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -143,7 +143,7 @@ jobs:
 
   radix-engine:
     name: Run Radix Engine tests
-    runs-on: gh-runner-scrypto-ubuntu-jammy-16-cores
+    runs-on: ubuntu-16-cores-selfhosted
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -165,7 +165,7 @@ jobs:
     # - overflow-checks
     # which are false for release variant
     name: Run Radix Engine tests (release)
-    runs-on: gh-runner-scrypto-ubuntu-jammy-16-cores
+    runs-on: ubuntu-16-cores-selfhosted
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -182,7 +182,7 @@ jobs:
 
   radix-engine-no-std:
     name: Run Radix Engine tests (no_std)
-    runs-on: gh-runner-scrypto-ubuntu-jammy-16-cores
+    runs-on: ubuntu-16-cores-selfhosted
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -199,7 +199,7 @@ jobs:
 
   radix-engine-wasmer:
     name: Run Radix Engine tests (wasmer)
-    runs-on: gh-runner-scrypto-ubuntu-jammy-16-cores
+    runs-on: ubuntu-16-cores-selfhosted
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -261,7 +261,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [gh-runner-scrypto-ubuntu-jammy-16-cores, windows-latest-16-cores]
+        os: [ubuntu-16-cores-selfhosted, windows-16-cores-selfhosted]
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -287,7 +287,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [gh-runner-scrypto-ubuntu-jammy-16-cores, windows-latest-16-cores, macos-latest]
+        os: [ubuntu-16-cores-selfhosted, windows-16-cores-selfhosted, macos-latest]
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -307,7 +307,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [gh-runner-scrypto-ubuntu-jammy-16-cores]
+        os: [ubuntu-16-cores-selfhosted]
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -320,7 +320,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [gh-runner-scrypto-ubuntu-jammy-16-cores]
+        os: [ubuntu-16-cores-selfhosted]
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Setup environment
@@ -330,7 +330,7 @@ jobs:
 
   determinism-test:
     name: Run determinism test
-    runs-on: gh-runner-scrypto-ubuntu-jammy-16-cores
+    runs-on: ubuntu-16-cores-selfhosted
     steps:
       - uses: RDXWorks-actions/checkout@main
       - name: Cargo Check

.github/workflows/publish-scrypto-builder.yml

@@ -16,7 +16,7 @@ jobs:
   build-amd:
     uses: radixdlt/public-iac-resuable-artifacts/.github/workflows/docker-build.yml@main
     with:
-      runs_on: gh-runner-scrypto-ubuntu-jammy-16-cores
+      runs_on: ubuntu-16-cores-selfhosted
       environment: "release"
       image_registry: "docker.io"
       image_organization: "radixdlt"

README.md

@@ -4,7 +4,7 @@
 
 Language for building DeFi apps on Radix.
 
-Documentation: https://docs-babylon.radixdlt.com/main/scrypto/introduction.html
+Documentation: https://docs.radixdlt.com/docs/scrypto-1
 
 
 ## Installation

radix-engine-common/src/lib.rs

@@ -36,9 +36,17 @@ pub use radix_engine_derive::{
     ScryptoDecode, ScryptoEncode, ScryptoEvent, ScryptoSbor,
 };
 
-// This is to make derives work within this crate.
-// See: https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
-pub extern crate self as radix_engine_common;
+// extern crate self as X; in lib.rs allows ::X and X to resolve to this crate inside this crate.
+// This enables procedural macros which output code involving paths to this crate, to work inside
+// this crate. See this link for details:
+// https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
+//
+// IMPORTANT:
+// This should never be pub, else `X::X::X::X::...` becomes a valid path in downstream crates,
+// which we've discovered can cause really bad autocomplete times (when combined with other
+// specific imports, generic traits, resolution paths which likely trigger edge cases in
+// Rust Analyzer which get stuck on these infinite possible paths)
+extern crate self as radix_engine_common;
 
 /// Each module should have its own prelude, which:
 /// * Adds preludes of upstream crates

radix-engine-interface/src/lib.rs

@@ -29,9 +29,17 @@ pub use radix_engine_common::*;
 pub extern crate sbor;
 pub use sbor::{Categorize, Decode, Encode, Sbor};
 
-// This is to make derives work within this crate.
-// See: https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
-pub extern crate self as radix_engine_interface;
+// extern crate self as X; in lib.rs allows ::X and X to resolve to this crate inside this crate.
+// This enables procedural macros which output code involving paths to this crate, to work inside
+// this crate. See this link for details:
+// https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
+//
+// IMPORTANT:
+// This should never be pub, else `X::X::X::X::...` becomes a valid path in downstream crates,
+// which we've discovered can cause really bad autocomplete times (when combined with other
+// specific imports, generic traits, resolution paths which likely trigger edge cases in
+// Rust Analyzer which get stuck on these infinite possible paths)
+extern crate self as radix_engine_interface;
 
 /// Each module should have its own prelude, which:
 /// * Adds preludes of upstream crates

radix-engine-tests/tests/vm/stack_size.rs

@@ -66,7 +66,7 @@ fn test_error_enum_sizes() {
     print_size!(AccessControllerError);
     print_size!(NonFungibleResourceManagerError);
 
-    check_size!(RuntimeError, 100);
+    check_size!(RuntimeError, 116);
     check_size!(KernelError, 100);
     check_size!(CallFrameError, 100);
     check_size!(SystemError, 100);

sbor/src/lib.rs

@@ -70,8 +70,16 @@ pub use sbor_derive::{
     Describe, Encode, Sbor,
 };
 
-// This is to make derives work within this crate.
-// See: https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
+// extern crate self as X; in lib.rs allows ::X and X to resolve to this crate inside this crate.
+// This enables procedural macros which output code involving paths to this crate, to work inside
+// this crate. See this link for details:
+// https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
+//
+// IMPORTANT:
+// This should never be pub, else `X::X::X::X::...` becomes a valid path in downstream crates,
+// which we've discovered can cause really bad autocomplete times (when combined with other
+// specific imports, generic traits, resolution paths which likely trigger edge cases in
+// Rust Analyzer which get stuck on these infinite possible paths)
 extern crate self as sbor;
 
 // For self-contained macros

scrypto/src/lib.rs

@@ -45,9 +45,17 @@ pub use radix_engine_interface::{
     address, api, blueprints, constants, crypto, data, math, network, schema, time, types,
 };
 
-// This is to make derives work within this crate.
-// See: https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
-pub extern crate self as scrypto;
+// extern crate self as X; in lib.rs allows ::X and X to resolve to this crate inside this crate.
+// This enables procedural macros which output code involving paths to this crate, to work inside
+// this crate. See this link for details:
+// https://users.rust-lang.org/t/how-can-i-use-my-derive-macro-from-the-crate-that-declares-the-trait/60502
+//
+// IMPORTANT:
+// This should never be pub, else `X::X::X::X::...` becomes a valid path in downstream crates,
+// which we've discovered can cause really bad autocomplete times (when combined with other
+// specific imports, generic traits, resolution paths which likely trigger edge cases in
+// Rust Analyzer which get stuck on these infinite possible paths)
+extern crate self as scrypto;
 
 /// Sets up panic hook.
 pub fn set_up_panic_hook() {