Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: try leader by label #819

Merged
merged 1 commit into from
Sep 21, 2023
Merged

*: try leader by label #819

merged 1 commit into from
Sep 21, 2023

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes # add tryleader command

What this PR does?

Summary:
use label to add tryleader command

Special notes for your reviewer?

@acekingke acekingke added the enhancement New feature or request label Sep 8, 2023
@acekingke acekingke added this to the Next milestone Sep 8, 2023
@acekingke acekingke self-assigned this Sep 8, 2023
caphash
caphash reviewed Sep 18, 2023
View reviewed changes
Copy link

@caphash caphash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. if the tryleader operator would be failed，then the label should also be deleted.
  2. the old leader should be set readonly before the tryleader operator and be closed after it, no matter whether it succeeded or not.

@acekingke acekingke merged commit 18939ac into radondb:main Sep 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-mao-oss tom-mao-oss tom-mao-oss approved these changes

@caphash caphash caphash approved these changes

Assignees

@acekingke acekingke

Labels
enhancement New feature or request
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
3 participants
@acekingke @caphash @tom-mao-oss