Add lots of improvements

- Stop on using `/tmp/cache.mp3` as a hardcoded string;
- Defer an os.Remove() for `/tmp/cache.mp3` in `exec()` function;
- Unpair bluetooth device on exiting;
- Fix bluetooth device auto pairing (a.k.a pairing restore);

Author: rafael-santiago

src/eutherpe.go

@@ -9,13 +9,14 @@ package main
 
 import (
     "internal/bluebraces"
-    "fmt"
     "internal/vars"
     "internal/webui"
-    "os"
-    "time"
     "internal/wifi"
     "internal/options"
+    "internal/mplayer"
+    "fmt"
+    "os"
+    "time"
     "strings"
 )
 
@@ -68,13 +69,16 @@ func exec() {
                                                 eutherpeVars.CachedDevices.BlueDevId)
     }
     fmt.Printf("info: Listen at %s:%s\n", eutherpeVars.HTTPd.Addr, eutherpeVars.HTTPd.Port)
-    os.Remove("/tmp/cache.mp3")
+    defer os.Remove(vars.EutherpeCachedMP3FilePath)
     webui.RunWebUI(eutherpeVars)
     eutherpeVars.HTTPd.AuthWatchdog.Off()
     eutherpeVars.SaveSession()
     if len(eutherpeVars.HostName) > 0 {
         eutherpeVars.MDNS.GoinHome <- true
     }
+    if len(eutherpeVars.CachedDevices.BlueDevId) > 0 {
+        bluebraces.UnpairDevice(eutherpeVars.CachedDevices.BlueDevId)
+    }
 }
 
 func version() {
@@ -99,7 +103,7 @@ func tryToPairWithPreviousBluetoothDevice(eutherpeVars *vars.EutherpeVars,
         eutherpeVars.Unlock()
         return
     }
-    blueDevs, _ := bluebraces.ScanDevices(3 * time.Second)
+    blueDevs, _ := bluebraces.ScanDevices(time.Duration(10 * time.Second))
     found := false
     for _, blueDev := range blueDevs {
         found = (blueDev.Id == previousDevice)
@@ -112,6 +116,9 @@ func tryToPairWithPreviousBluetoothDevice(eutherpeVars *vars.EutherpeVars,
         err = bluebraces.PairDevice(previousDevice)
         if err == nil {
             err = bluebraces.ConnectDevice(previousDevice)
+            if err == nil {
+                eutherpeVars.CachedDevices.MixerControlName, err = bluebraces.GetBlueAlsaMixerControlName()
+            }
         }
     } else {
         err = fmt.Errorf("Previous device powered off.")
@@ -121,5 +128,8 @@ func tryToPairWithPreviousBluetoothDevice(eutherpeVars *vars.EutherpeVars,
     if shouldTryAgain  {
         time.Sleep(3 * time.Second)
         go tryToPairWithPreviousBluetoothDevice(eutherpeVars, previousDevice)
+    } else {
+        mplayer.SetVolume(int(eutherpeVars.Player.VolumeLevel),
+                          eutherpeVars.CachedDevices.MixerControlName)
     }
 }

src/internal/actions/music_play.go

@@ -66,8 +66,8 @@ func MusicPlay(eutherpeVars *vars.EutherpeVars, userData *url.Values) error {
     //               I believe that some nosy compiler "optimzation" was causing the
     //               inconsistence, not sure. I have been facing this issue on Go 1.19. :S
     shouldSetVolume := eutherpeVars.Player.Stopped || len(customPath) > 0
-    createCache(eutherpeVars.Player.NowPlaying.FilePath, "/tmp/cache.mp3")
-    eutherpeVars.Player.Handle, err = mplayer.Play("/tmp/cache.mp3", len(eutherpeVars.CachedDevices.BlueDevId) > 0, customPath)
+    createCache(eutherpeVars.Player.NowPlaying.FilePath, vars.EutherpeCachedMP3FilePath)
+    eutherpeVars.Player.Handle, err = mplayer.Play(vars.EutherpeCachedMP3FilePath, len(eutherpeVars.CachedDevices.BlueDevId) > 0, customPath)
     eutherpeVars.Player.Stopped = (err != nil)
     if eutherpeVars.Player.Stopped {
         return err
@@ -112,4 +112,3 @@ func createCache(src, dest string) {
     input, _ := ioutil.ReadFile(src)
     ioutil.WriteFile(dest, input, 0644)
 }
-

src/internal/actions/probe_bluetooth_devices.go

@@ -13,7 +13,6 @@ import (
     "flag"
     "net/url"
     "time"
-    "fmt"
 )
 
 func ProbeBluetoothDevices(eutherpeVars *vars.EutherpeVars,
@@ -26,7 +25,6 @@ func ProbeBluetoothDevices(eutherpeVars *vars.EutherpeVars,
     }
     blueDevs, err := bluebraces.ScanDevices(time.Duration(10 * time.Second), customPath)
     if err != nil {
-        fmt.Print(err)
         return err
     }
     eutherpeVars.BluetoothDevices = blueDevs

src/internal/vars/vars.go

@@ -693,3 +693,5 @@ const EutherpeMusicDevRootDir = ".eutherpe"
 const EutherpeMusicDevPlaylistsDir = "playlists"
 
 const EutherpeOptionListenPort = "listen-port"
+
+const EutherpeCachedMP3FilePath = "/tmp/cache.mp3"