Test in edit formsets skipping deleted attachments

rafalp · Jan 11, 2025 · 0f97a23 · 0f97a23
1 parent 7169c5f
commit 0f97a23
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/misago/conftest.py b/misago/conftest.py
@@ -536,6 +536,7 @@ def _attachment_factory(
         uploader=None,
         post=None,
         thumbnail_path=None,
+        is_deleted=False,
     ):
         filename = filename or str(os.path.split(file_path)[-1])
         filetype = filetypes.match_filetype(filename)
@@ -583,6 +584,7 @@ def _attachment_factory(
             image=image,
             video=video,
             file=file,
+            is_deleted=is_deleted,
         )
 
     return _attachment_factory

diff --git a/misago/posting/tests/test_formsets.py b/misago/posting/tests/test_formsets.py
@@ -355,6 +355,9 @@ def test_get_edit_thread_formset_loads_post_attachments(
     attachment_factory(text_file, uploader=other_user, post=other_thread.first_post)
     attachment_factory(text_file, uploader=user)
     attachment_factory(text_file, uploader=other_user)
+    attachment_factory(
+        text_file, uploader=user, post=thread.first_post, is_deleted=True
+    )
 
     formset = get_edit_thread_formset(request, thread.first_post)
     assert formset.title
@@ -459,6 +462,12 @@ def test_get_edit_private_thread_formset_loads_post_attachments(
     )
     attachment_factory(text_file, uploader=user)
     attachment_factory(text_file, uploader=other_user)
+    attachment_factory(
+        text_file,
+        uploader=user,
+        post=other_user_private_thread.first_post,
+        is_deleted=True,
+    )
 
     formset = get_edit_private_thread_formset(request, private_thread.first_post)
     assert formset.title
@@ -572,6 +581,9 @@ def test_get_edit_thread_post_formset_loads_post_attachments(
     attachment_factory(text_file, uploader=other_user, post=other_thread.first_post)
     attachment_factory(text_file, uploader=user)
     attachment_factory(text_file, uploader=other_user)
+    attachment_factory(
+        text_file, uploader=user, post=thread.first_post, is_deleted=True
+    )
 
     formset = get_edit_thread_post_formset(request, thread.first_post)
     assert not formset.title
@@ -676,6 +688,9 @@ def test_get_edit_private_thread_post_formset_loads_post_attachments(
     )
     attachment_factory(text_file, uploader=user)
     attachment_factory(text_file, uploader=other_user)
+    attachment_factory(
+        text_file, uploader=user, post=private_thread.first_post, is_deleted=True
+    )
 
     formset = get_edit_private_thread_post_formset(request, private_thread.first_post)
     assert not formset.title