-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachments v2 #1813
Open
rafalp
wants to merge
180
commits into
main
Choose a base branch
from
fix-1805-move-attachemts-to-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Attachments v2 #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
added
the
area: backend
This issue involves Python, Django or dependency (eg. database)
label
Sep 10, 2024
rafalp
force-pushed
the
fix-1805-move-attachemts-to-app
branch
from
September 15, 2024 09:25
0cc2750
to
96fb0a4
Compare
rafalp
force-pushed
the
fix-1805-move-attachemts-to-app
branch
from
January 5, 2025 12:20
96fb0a4
to
ef1b351
Compare
…permissions object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: backend
This issue involves Python, Django or dependency (eg. database)
feature: admin
Affects admin control panel
feature: posting
Start/reply/edit flows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements new attachments feature as
misago.attachments
app, makingmisago.threads
smaller. Also brings attachments feature closer to the industry standard.Fixes #1805, #1813, and #1812
Also does part of the #1801
TODO
misago.attachments
appmisago.threads
misago.attachments
Attachment
modelmisago.admin
plugin_data
PostForm
PostForm
in private threadsPostForm
attachments handling logicis_deleted
flag in adminX-Accel-Redirect
to secure downloads<attachment=filename.jpg:123>
syntax to messages parserPostForm
(without JavaScript)PostForm
(with JavaScript)PostForm
(JavaScript + paste file)PostForm
(JavaScript + drag and drop)Posting forms
Manually verify and write tests for file uploads and deletion on those forms:
Scenarios to test
Views to test: