Sourcery refactored main branch #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| path = 'templates/' + templateFile | ||
| path = f'templates/{templateFile}' |
There was a problem hiding this comment.
Function applyTemplate refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-21
to
+25
| def fromJson(text): | ||
| tmp = json.loads(text, object_hook=lambda d: label( | ||
| d['name'], d['description'], d['color'])) | ||
| def fromJson(self): | ||
| tmp = json.loads( | ||
| self, | ||
| object_hook=lambda d: label(d['name'], d['description'], d['color']), | ||
| ) |
There was a problem hiding this comment.
Function label.fromJson refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
Comment on lines
-38
to
+56
| cmd = 'gh label {}'.format(self.option) | ||
| repo = '-R {}/{}'.format(owner, repo) | ||
| cmd = f'gh label {self.option}' | ||
| repo = f'-R {owner}/{repo}' | ||
|
|
||
| append = str() | ||
|
|
||
| if self.option == 'create': | ||
| label = '\"{}\" --description \"{}\" --color {}'.format( | ||
| self.name, self.label.description, self.label.color.replace("#", "")) | ||
| append = '-f {}'.format(label) | ||
| label = f'\"{self.name}\" --description \"{self.label.description}\" --color {self.label.color.replace("#", "")}' | ||
| append = f'-f {label}' | ||
| elif self.option == 'edit': | ||
| nameChanged = self.name != self.label.name | ||
| append = '\"{}\" --description \"{}\" --color {}'.format( | ||
| self.name, self.label.description, self.label.color.replace("#", "")) | ||
| append = f'\"{self.name}\" --description \"{self.label.description}\" --color {self.label.color.replace("#", "")}' | ||
| if nameChanged: | ||
| append += ' --name \"{}\"'.format(self.label.name) | ||
| append += f' --name \"{self.label.name}\"' | ||
| elif self.option == 'delete': | ||
| append = '\"{}\" --yes'.format(self.name) | ||
| append = f'\"{self.name}\" --yes' | ||
|
|
||
| fullCommand = '{} {} {}'.format(cmd, repo, append) | ||
| fullCommand = f'{cmd} {repo} {append}' |
There was a problem hiding this comment.
Function action.execute refactored with the following changes:
- Replace call to format with f-string [×8] (
use-fstring-for-formatting)
Comment on lines
-65
to
+75
| repo = '-R {}/{}'.format(owner, repo) | ||
| repo = f'-R {owner}/{repo}' | ||
| condition = '--json name,description,color' | ||
| jq = '--jq \".[]\"' | ||
|
|
||
| fullCommand = '{} {} {} {}'.format(cmd, repo, condition, jq) | ||
| fullCommand = f'{cmd} {repo} {condition} {jq}' | ||
|
|
||
| process = os.popen(fullCommand) | ||
| output = process.read().splitlines() | ||
| process.close() | ||
|
|
||
| labels = [label.fromJson(x) for x in output if x != ''] | ||
|
|
||
| return labels | ||
| return [label.fromJson(x) for x in output if x != ''] |
There was a problem hiding this comment.
Function getLabels refactored with the following changes:
- Replace call to format with f-string [×2] (
use-fstring-for-formatting) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-35
to
+37
| def build(path): | ||
| if os.path.exists(path): | ||
| with open(path, 'r') as file: | ||
| def build(self): | ||
| if os.path.exists(self): | ||
| with open(self, 'r') as file: |
There was a problem hiding this comment.
Function labelsTemplate.build refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
| process = os.popen('{} {} {} {}'.format(cmd, owner, json, jq)) | ||
| process = os.popen(f'{cmd} {owner} {json} {jq}') |
There was a problem hiding this comment.
Function labelsTemplate.applyToRepos refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-102
to
+106
| for x in templateLabelsNames: | ||
| if not currentLabelsNames.__contains__(x): | ||
| actions.append( | ||
| action('create', x, self.labels[templateLabelsNames.index(x)])) | ||
|
|
||
| actions.extend( | ||
| action('create', x, self.labels[templateLabelsNames.index(x)]) | ||
| for x in templateLabelsNames | ||
| if not currentLabelsNames.__contains__(x) | ||
| ) |
There was a problem hiding this comment.
Function labelsTemplate.apply refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!