Updated descriptions below main header pages #444
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdded subtitle/description rendering under dashboard headers and threaded a new required Changes
Sequence Diagram(s)(omitted — changes are UI/text additions; no control-flow or new interactions to diagram) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello @raghavyuva , please review this PR and provide feedback if possible. |
|
@zhravan tagging you for review |
|
@muhammadrafayasif: Everything looks good to me! Can you add the same for Self Hosted screen as well? For the self host screen, we are missing this particular Muted title description. Rest all LGTM. 
Steps to reproduce:
|
Thanks for pointing this out, I'll be sure to resolve it by tonight! |
@zhravan Unfortunately, I am unable to access this page due to the app being set up on localhost causing GitHub to throw this error. I've tried setting it up on cloudflare so I can access this page, but I ended up facing difficulties integrating with the database... |
@muhammadrafayasif : Add a dummy URL in frontend for webhook in .env : WEBHOOK_URL=https://smee.io/xxxx |
|
Thanks for your support @zhravan, I've added a muted title description to this page as per your request. Additionally, the French locale didn't have the translations for the repository page so I added that too. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
view/app/self-host/components/github-repositories/list-repositories.tsx(1 hunks)view/components/layout/dashboard-page-header.tsx(2 hunks)view/lib/i18n/locales/en.json(5 hunks)view/lib/i18n/locales/es.json(5 hunks)view/lib/i18n/locales/fr.json(5 hunks)view/lib/i18n/locales/kn.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- view/lib/i18n/locales/en.json
- view/lib/i18n/locales/fr.json
🧰 Additional context used
🧬 Code graph analysis (1)
view/components/layout/dashboard-page-header.tsx (1)
view/components/ui/typography.tsx (2)
TypographyH2(9-15)TypographyMuted(73-77)
🔇 Additional comments (3)
view/app/self-host/components/github-repositories/list-repositories.tsx (1)
66-66: LGTM! Addresses reviewer feedback.The addition of the
descriptionprop successfully addresses the reviewer's request to add a description to the Self Hosted repositories screen.view/lib/i18n/locales/kn.json (1)
19-19: LGTM! Kannada translations align with Spanish updates.The Kannada translations for the description fields are consistent with the Spanish locale updates and properly support the new description prop functionality.
Also applies to: 193-193, 378-378, 794-794, 1214-1214
view/components/layout/dashboard-page-header.tsx (1)
35-35: LGTM – all<DashboardUtilityHeader>usages now include the requireddescriptionprop.
| "containers": { | ||
| "title": "Contenedores", | ||
| "description": "Vista previa de todos los contenedores", | ||
| "description": "Ver y administrar sus contenedores en ejecución o detenidos", |
There was a problem hiding this comment.
🧩 Analysis chain
LGTM! Verify other locales updated.
The Spanish translations for the description fields are well-formed and contextually appropriate. Ensure that the corresponding translation keys in en.json and fr.json have also been updated, as mentioned in the PR objectives.
Run the following script to verify all locale files have the required keys:
Also applies to: 192-192, 421-421, 797-797, 1213-1213
🏁 Script executed:
#!/bin/bash
# Description: Verify translation keys exist in all locale files
# Check for repositories.description in all locale files
echo "Checking repositories.description key:"
fd -e json . view/lib/i18n/locales/ --exec grep -l "repositories.description"
# Check for other updated description keys
echo -e "\nChecking other description keys:"
for key in "containers.description" "settings.description" "domains.page.description" "fileManager.header.subtitle"; do
echo "Key: $key"
fd -e json . view/lib/i18n/locales/ --exec grep -l "$key"
doneLength of output: 189
🏁 Script executed:
#!/bin/bash
DIR="view/lib/i18n/locales"
keys=("containers.description" "settings.description" "domains.page.description" "fileManager.header.subtitle" "repositories.description")
for file in "$DIR"/*.json; do
echo "$file:"
for key in "${keys[@]}"; do
top="${key%%.*}"
sub="${key#*.}"
if jq -e --arg top "$top" --arg sub "$sub" 'has($top) and .[$top] | has($sub)' "$file" > /dev/null; then
echo " $key: found"
else
echo " $key: missing"
fi
done
doneLength of output: 2771
🏁 Script executed:
#!/bin/bash
FILE="view/lib/i18n/locales/es.json"
echo "=== Top of $FILE ==="
sed -n '1,50p' "$FILE"
echo -e "\n=== Around error line 1311 in $FILE ==="
sed -n '1280,1360p' "$FILE"Length of output: 3103
🏁 Script executed:
#!/usr/bin/env python3
import json, glob, os
keys = [
"containers.description",
"settings.description",
"domains.page.description",
"fileManager.header.subtitle",
"repositories.description"
]
locale_dir = "view/lib/i18n/locales"
for filepath in sorted(glob.glob(os.path.join(locale_dir, "*.json"))):
print(f"{os.path.basename(filepath)}:")
try:
data = json.load(open(filepath, encoding="utf-8"))
except Exception as e:
print(f" Error parsing JSON: {e}")
continue
for key in keys:
parts = key.split(".")
d = data
found = True
for part in parts:
if isinstance(d, dict) and part in d:
d = d[part]
else:
found = False
break
print(f" {key}: {'found' if found else 'missing'}")
print()Length of output: 654
🏁 Script executed:
#!/usr/bin/env bash
LOCALE_DIR="view/lib/i18n/locales"
keys=("containers.description" "settings.description" "domains.page.description" "fileManager.header.subtitle" "repositories.description")
for file in "$LOCALE_DIR"/*.json; do
echo "Checking $file"
python3 - "$file" << 'EOF'
import json, sys
path = sys.argv[1]
data = json.load(open(path, encoding="utf-8"))
keys = ["containers.description","settings.description","domains.page.description","fileManager.header.subtitle","repositories.description"]
for key in keys:
d = data
for part in key.split("."):
if isinstance(d, dict) and part in d:
d = d[part]
else:
print(f"{key}: missing")
break
else:
print(f"{key}: found")
EOF
doneLength of output: 799
Add missing translation keys in all locales
- domains.page.description
- repositories.description
These keys are absent fromview/lib/i18n/locales/*.json. Add them with appropriate translations toen.json,es.json,fr.json, andkn.json.
🤖 Prompt for AI Agents
In view/lib/i18n/locales/es.json around line 18, the locale is missing keys
"domains.page.description" and "repositories.description"; add them with
appropriate Spanish translations (e.g., domains.page.description: "Ver y
administrar sus dominios" and repositories.description: "Ver y administrar sus
repositorios"); also add the same two keys to view/lib/i18n/locales/en.json,
fr.json and kn.json with appropriate translations for each locale (English:
"View and manage your domains" / "View and manage your repositories"; French:
"Afficher et gérer vos domaines" / "Afficher et gérer vos dépôts"; Kannada:
provide correct Kannada equivalents), ensuring JSON keys are added in the same
structure and any trailing commas / formatting follow existing file style.
|
@muhammadrafayasif: Can you share a video recording of the same for reference? |
|
@zhravan: here you go video.mp4 |
|
@muhammadrafayasif: Will do final review and merge it for coming release cycle. |
zhravan
added
enhancement
@muhammadrafayasif Hey in the video, for Self Hosted Application, I still see no log Header Description? Otherwise rest looks good |
Sorry I don't understand, I didn't see any log header title during development? |
@muhammadrafayasif: Check usage of Ref: https://github.com/raghavyuva/nixopus/blob/master/view/components/layout/dashboard-page-header.tsx |
Alright thanks, I'll take a look and commit soon 👌 |
github-actions
bot
force-pushed
the
feat/develop
branch
25 times, most recently
from
da06208 to
b915b03
Compare
github-actions
bot
force-pushed
the
feat/develop
branch
5 times, most recently
from
927519c to
1c41294
Compare
3 participants
According to the issue, I changed the descriptions of every major title in all locales.
Resolves #435
Summary by CodeRabbit
New Features
Style
Localization