-
-
Notifications
You must be signed in to change notification settings - Fork 71
feat(support-odia) : supports odia langugae translations in nixopus #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdds Odia ("or") localization: extends the locales list and languageNames mapping, adds "or" entries to existing locale language maps, and introduces a full Odia locale file with translations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related issues
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
view/lib/i18n/locales/or.json (1)
218-228: Font coverage note for Odia glyphs (optional).Ensure UI font stacks include a fallback with Odia coverage (e.g., Noto Sans Oriya) so glyphs render correctly across OSes.
Also applies to: 1326-1372
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
view/lib/i18n/config.ts(1 hunks)view/lib/i18n/locales/en.json(1 hunks)view/lib/i18n/locales/es.json(1 hunks)view/lib/i18n/locales/fr.json(1 hunks)view/lib/i18n/locales/kn.json(1 hunks)view/lib/i18n/locales/ml.json(1 hunks)view/lib/i18n/locales/or.json(1 hunks)
🔇 Additional comments (7)
view/lib/i18n/locales/en.json (1)
765-767: Add Odia label — looks good.Entry is correct and consistent with existing language map.
view/lib/i18n/locales/es.json (1)
748-750: Added Odia label — OK.Consistent with other locales.
view/lib/i18n/locales/fr.json (1)
749-751: Odia language entry added — LGTM.No issues spotted.
view/lib/i18n/locales/ml.json (1)
764-766: Malayalam map updated with Odia — good.Spelling looks correct.
view/lib/i18n/locales/kn.json (1)
745-747: Kannada map updated with Odia — good.Consistent with pattern.
view/lib/i18n/locales/or.json (1)
760-767: Languages map includes Odia endonym — good.Ensures the selector shows “ଓଡ଼ିଆ” when in Odia UI.
view/lib/i18n/config.ts (1)
2-2: All checks passed — locale integration for 'or' is complete.Verification confirms:
or.jsonexists in the locale bundles- Language switcher iterates over
localesarray and creates selector options for all locales including 'or'- Dynamic import in
use-translation.tsresolvesor.jsoncorrectly- Type safety maintained via
Localetype derived from thelocalesarray- Display name correctly mapped in
languageNamesRecordNo gaps in implementation.
|
@ashwintemkar: Please once comment on the issue, will assign this to you! We will review and release this in coming release cycle. |
Yes, sure @zhravan I've commented in the issue. Also I had informed and was in communication on discord. |
Issue
This PR solves #502
Description
Adds Odia (
or) locale support to the app: registers the locale in the i18n config, updates existing locale manifests, and introduces the full Odia translation bundle.Scope of Change
Select all applicable areas impacted by this PR:
Screenshot / Video / GIF (if applicable)
Attach or embed screenshots, screen recordings, or GIFs demonstrating the feature or fix.
N/A
Related PRs (if any)
Link any related or dependent PRs across repos.
below image shows translation correclty
below image shows the Odia translation option in the selector for all languages
Additional Notes for Reviewers (optional)
view/lib/i18n/locales/or.jsonentries and the locale registration inview/lib/i18n/config.ts.Developer Checklist
To be completed by the developer who raised the PR.
Reviewer Checklist
To be completed by the reviewer before merge.
Summary by CodeRabbit