Skip to content

Conversation

@ashwintemkar
Copy link

@ashwintemkar ashwintemkar commented Oct 28, 2025

Issue

This PR solves #502


Description

Adds Odia (or) locale support to the app: registers the locale in the i18n config, updates existing locale manifests, and introduces the full Odia translation bundle.


Scope of Change

Select all applicable areas impacted by this PR:

  • View (UI/UX)
  • API
  • CLI
  • Infra / Deployment
  • Docs
  • Other (specify): ________

Screenshot / Video / GIF (if applicable)

Attach or embed screenshots, screen recordings, or GIFs demonstrating the feature or fix.
N/A


Related PRs (if any)

Link any related or dependent PRs across repos.

below image shows translation correclty

image

below image shows the Odia translation option in the selector for all languages

image


Additional Notes for Reviewers (optional)

  • Focus review on the new view/lib/i18n/locales/or.json entries and the locale registration in view/lib/i18n/config.ts.

Developer Checklist

To be completed by the developer who raised the PR.

  • Add valid/relevant title for the PR
  • Self-review done
  • Manual dev testing done
  • No secrets exposed
  • No merge conflicts
  • Docs added/updated (if applicable)
  • Removed debug prints / secrets / sensitive data
  • Unit / Integration tests passing
  • Follows all standards defined in Nixopus Docs

Reviewer Checklist

To be completed by the reviewer before merge.

  • Peer review done
  • No console.logs / fmt.prints left
  • No secrets exposed
  • If any DB migrations, migration changes are verified
  • Verified release changes are production-ready

Summary by CodeRabbit

  • New Features
    • Full Odia (Oriya) language added with complete UI translations.
    • Supported locales extended to include Odia.
    • Language selectors and menus updated across locales so Odia appears as an option.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

Adds Odia ("or") localization: extends the locales list and languageNames mapping, adds "or" entries to existing locale language maps, and introduces a full Odia locale file with translations.

Changes

Cohort / File(s) Change Summary
I18n Configuration
view/lib/i18n/config.ts
Extended locales array to include 'or' and added languageNames.or = 'ଓଡ଼ିଆ'.
Existing Locale Files
view/lib/i18n/locales/{en.json,es.json,fr.json,kn.json,ml.json}
Added "or" entry to each file's languages map (locale-appropriate label for Odia).
New Odia Locale File
view/lib/i18n/locales/or.json
Added full Odia (or) locale JSON with translations for UI sections (auth, dashboard, settings, notifications, dialogs, etc.).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review completeness and key parity in view/lib/i18n/locales/or.json.
  • Verify JSON syntax/formatting across modified files.
  • Confirm languages entries are consistent and localized labels are correct.

Possibly related issues

Possibly related PRs

Suggested labels

nixopus-view

Poem

🐰
I hopped through config, gentle and spry,
Planted 'or' where languages lie.
Menus now hum an Odia tune,
Small patch, bright as a midday moon! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "feat(support-odia) : supports odia langugae translations in nixopus" is clearly and directly related to the main change in the changeset, which is adding Odia language support to the application. The title specifically references the feature being added (Odia language), and the raw summary confirms that all changes revolve around implementing Odia (locale code 'or') translations across configuration files, locale mappings, and a new complete Odia translation bundle. A teammate scanning the repository history would immediately understand that this pull request adds Odia language support. While there are minor quality issues—including a typo ("langugae" instead of "language"), unconventional formatting with a colon separator, and some redundancy between the feature prefix and the description—these do not prevent the title from clearly conveying the primary change.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31c9248 and e950e57.

📒 Files selected for processing (5)
  • view/lib/i18n/locales/en.json (1 hunks)
  • view/lib/i18n/locales/es.json (1 hunks)
  • view/lib/i18n/locales/fr.json (1 hunks)
  • view/lib/i18n/locales/kn.json (1 hunks)
  • view/lib/i18n/locales/ml.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • view/lib/i18n/locales/fr.json
  • view/lib/i18n/locales/kn.json
  • view/lib/i18n/locales/en.json
  • view/lib/i18n/locales/es.json
🔇 Additional comments (1)
view/lib/i18n/locales/ml.json (1)

764-765: LGTM! Odia language entry correctly added to Malayalam locale manifest.

The new Odia language entry follows the existing pattern and uses the correct ISO 639-1 locale code (or). The script rendering appears correct. This metadata addition is consistent with the i18n configuration updates mentioned in the PR objectives.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
view/lib/i18n/locales/or.json (1)

218-228: Font coverage note for Odia glyphs (optional).

Ensure UI font stacks include a fallback with Odia coverage (e.g., Noto Sans Oriya) so glyphs render correctly across OSes.

Also applies to: 1326-1372

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 577cf5c and cb0c052.

📒 Files selected for processing (7)
  • view/lib/i18n/config.ts (1 hunks)
  • view/lib/i18n/locales/en.json (1 hunks)
  • view/lib/i18n/locales/es.json (1 hunks)
  • view/lib/i18n/locales/fr.json (1 hunks)
  • view/lib/i18n/locales/kn.json (1 hunks)
  • view/lib/i18n/locales/ml.json (1 hunks)
  • view/lib/i18n/locales/or.json (1 hunks)
🔇 Additional comments (7)
view/lib/i18n/locales/en.json (1)

765-767: Add Odia label — looks good.

Entry is correct and consistent with existing language map.

view/lib/i18n/locales/es.json (1)

748-750: Added Odia label — OK.

Consistent with other locales.

view/lib/i18n/locales/fr.json (1)

749-751: Odia language entry added — LGTM.

No issues spotted.

view/lib/i18n/locales/ml.json (1)

764-766: Malayalam map updated with Odia — good.

Spelling looks correct.

view/lib/i18n/locales/kn.json (1)

745-747: Kannada map updated with Odia — good.

Consistent with pattern.

view/lib/i18n/locales/or.json (1)

760-767: Languages map includes Odia endonym — good.

Ensures the selector shows “ଓଡ଼ିଆ” when in Odia UI.

view/lib/i18n/config.ts (1)

2-2: All checks passed — locale integration for 'or' is complete.

Verification confirms:

  • or.json exists in the locale bundles
  • Language switcher iterates over locales array and creates selector options for all locales including 'or'
  • Dynamic import in use-translation.ts resolves or.json correctly
  • Type safety maintained via Locale type derived from the locales array
  • Display name correctly mapped in languageNames Record

No gaps in implementation.

@zhravan
Copy link
Collaborator

zhravan commented Oct 28, 2025

@ashwintemkar: Please once comment on the issue, will assign this to you! We will review and release this in coming release cycle.

@ashwintemkar
Copy link
Author

@ashwintemkar: Please once comment on the issue, will assign this to you! We will review and release this in coming release cycle.

Yes, sure @zhravan I've commented in the issue.

Also I had informed and was in communication on discord.

@zhravan zhravan added hacktoberfest Issues relevant to the Hacktoberfest event hacktoberfest-accepted PRs accepted under Hacktober Fest event hacktoberfest2025 Issues for Hacktoberfest event - 2025 labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Issues relevant to the Hacktoberfest event hacktoberfest2025 Issues for Hacktoberfest event - 2025 hacktoberfest-accepted PRs accepted under Hacktober Fest event

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants