vmec_fieldlines: reduced number of iterations for root finding #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR hiddenSymmetries#243 looks good now. The little difference in this commit is the x0 for root finding is changed from
theta_guess - 1.0
totheta_guess
, which gives a modest reduction in the number of iterations required for root-finding in theVmecFieldlinesTests
tests. The scipy.optimize.newton routine being used now does not require the root to be bracketed, so the algorithm converges to the root faster by starting with this more accurate guess.BTW we can ignore the failing "Docker container" CI - it fails in forks because a password is not available.