Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly join simulation thread handles for sram simulation #454

Merged
merged 2 commits into from
Sep 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions src/blocks/gate/mod.rs
Original file line number Diff line number Diff line change
@@ -1,19 +1,14 @@
use std::collections::HashSet;

use serde::{Deserialize, Serialize};
use substrate::{
component::Component,
layout::{
cell::{CellPort, PortConflictStrategy},
layers::selector::Selector,
placement::{align::AlignMode, array::ArrayTiler},
},
};

use super::decoder::{
self,
layout::{DecoderGate, DecoderGateParams, DecoderTap},
};
use substrate::component::Component;
use substrate::layout::cell::{CellPort, PortConflictStrategy};
use substrate::layout::layers::selector::Selector;
use substrate::layout::placement::align::AlignMode;
use substrate::layout::placement::array::ArrayTiler;

use super::decoder::layout::{DecoderGate, DecoderGateParams, DecoderTap};
use super::decoder::{self};

pub mod layout;
pub mod schematic;
Expand Down
11 changes: 4 additions & 7 deletions src/blocks/rmux/mod.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
use serde::Serialize;
use substrate::{
component::Component,
layout::{
cell::{CellPort, PortConflictStrategy},
placement::{align::AlignMode, array::ArrayTiler},
},
};
use substrate::component::Component;
use substrate::layout::cell::{CellPort, PortConflictStrategy};
use substrate::layout::placement::align::AlignMode;
use substrate::layout::placement::array::ArrayTiler;

mod layout;
mod schematic;
Expand Down
5 changes: 4 additions & 1 deletion src/blocks/sram/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ pub(crate) mod tests {
let work_dir = work_dir.clone();
handles.push(std::thread::spawn(move || {
let ctx = setup_ctx();
let tb = crate::blocks::sram::testbench::tb_params(params, vdd, short, pex_netlist);
let tb = crate::blocks::sram::testbench::tb_params(params, vdd, short, None);
let work_dir = work_dir.join(format!(
"{}_{:.2}_{}",
corner.name(),
Expand All @@ -480,6 +480,9 @@ pub(crate) mod tests {
}));
}
}
for handle in handles {
handle.join().expect("failed to join thread");
}

// crate::abs::run_abstract(
// &work_dir,
Expand Down
10 changes: 5 additions & 5 deletions src/blocks/sram/testbench/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -417,11 +417,11 @@ impl Testbench for SramTestbench {
.unwrap(),
);

let signals = (0..self.params.sram.data_width)
.map(|i| format!("dout[{i}]"))
.collect();
ctx.save(Save::Signals(signals));
// ctx.save(Save::All);
// let signals = (0..self.params.sram.data_width)
// .map(|i| format!("dout[{i}]"))
// .collect();
// ctx.save(Save::Signals(signals));
ctx.save(Save::All);

let vdd = SiValue::with_precision(self.params.vdd, SiPrefix::Nano);

Expand Down
11 changes: 4 additions & 7 deletions src/blocks/wmux/mod.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
use serde::{Deserialize, Serialize};
use substrate::{
component::Component,
layout::{
cell::{CellPort, PortConflictStrategy, PortId},
placement::{align::AlignMode, array::ArrayTiler},
},
};
use substrate::component::Component;
use substrate::layout::cell::{CellPort, PortConflictStrategy, PortId};
use substrate::layout::placement::align::AlignMode;
use substrate::layout::placement::array::ArrayTiler;

mod layout;
mod schematic;
Expand Down
Loading