Соболев Александр#8
Open
Soblev515 wants to merge 4 commits intorailbotan:mainfrom
Hidden character warning
The head ref may contain hidden characters: "\u0421\u043e\u0431\u043e\u043b\u0435\u0432-\u0410\u043b\u0435\u043a\u0441\u0430\u043d\u0434\u0440"
Open
Conversation
railbotan
reviewed
Nov 14, 2021
| average = self.__GetAverage(y, x) | ||
| self.arr[y: y + self.mosaic_size, x: x + self.mosaic_size] = int(average // self.grayscale) * self.grayscale | ||
|
|
||
| def __SaveResult(self, newIMG): |
Owner
There was a problem hiding this comment.
Если вы сохраняете изображение внутри метода класса, то открывать изображение также желательно внутри метода класса.
railbotan
reviewed
Nov 14, 2021
| self.__SaveResult(newIMG) | ||
|
|
||
| img = Image.open(input("Введите название изображение: ")) | ||
| filtr = Filter(img, 10, 50) |
Owner
There was a problem hiding this comment.
Размер блока и количество градаций тоже можно было считывать с консоли. Также должно подаваться количество градаций, исходя из которого уже вычисляется шаг.
Owner
|
5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Исправлены четыре ошибки, которые заставляли фильтр работать не так, как нужно: