Галкин Даниил #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
налажена работа с граничными условиями, в результате чего справа и внизу не остаётся необработанных полос по 10 пикселей исправлена формула расчёта компонентов серого цвета исправлено неверные название переменной
Были переименованы переменные, названия стали более понятны Добавлена возможность управлять размерами мозайки и градациями серого Были выделены функции
…льтата, путь изображения, количество градаций и размер мозайки
railbotan
reviewed
Nov 20, 2021
filter.py
Outdated
| gradations = 255 // count_gradations | ||
| pixel_x = 0 | ||
|
|
||
| def find_average_brightness(array, px_width, px_height, mosaic): |
Owner
There was a problem hiding this comment.
Функция find_average_brightness создается внутри функции do_filter при каждом вызове do_filter. Функция find_average_brightness должна быть объявлена вне функции do_filter
railbotan
reviewed
Nov 20, 2021
filter.py
Outdated
| average_bright = int(sum_brightness // mosaic_size ** 2) | ||
| return average_bright | ||
|
|
||
| def paint_cell(array, px_width, px_height, mosaic): |
Owner
There was a problem hiding this comment.
Аналогично с find_average_brightness
Owner
|
Все ОК! |
Owner
|
5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.