Use array args instead of string args for system command #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
commented
Jan 1, 2024
Comment on lines
+21
to
+25
| exclude: | ||
| - ruby-version: "3.0" | ||
| gemfile: gemfiles/rails_main_propshaft.gemfile | ||
| - ruby-version: "3.0" | ||
| gemfile: gemfiles/rails_main_sprockets.gemfile |
There was a problem hiding this comment.
The main branch no longer install on ruby 3.0, therefore exclude them from the test.
| end | ||
|
|
||
| def dartsass_build_options | ||
| Rails.application.config.dartsass.build_options | ||
| Rails.application.config.dartsass.build_options.flat_map(&:split) |
There was a problem hiding this comment.
split is used for compatibility with <=0.5.0, where build_options are simply concatenated strings:
--option(with a space prefix) will become["--option"].--option1 --option2will become["--option1", "--option2"]
| end | ||
|
|
||
| def dartsass_compile_command | ||
| "#{EXEC_PATH} #{dartsass_build_options} #{dartsass_load_paths} #{dartsass_build_mapping}" | ||
| [ RbConfig.ruby, EXEC_PATH ].concat(dartsass_build_options).concat(dartsass_load_paths).concat(dartsass_build_mapping) |
There was a problem hiding this comment.
Adding RbConfig.ruby so that it works on windows as well.
| end | ||
|
|
||
| namespace :dartsass do | ||
| desc "Build your Dart Sass CSS" | ||
| task build: :environment do | ||
| system dartsass_compile_command, exception: true | ||
| system(*dartsass_compile_command, exception: true) |
There was a problem hiding this comment.
The array form of system does not invoke a shell. It invoke the binary directly, therefore it is faster and safer.
|
@dhh I have added some comments explaining the changes here. Would you mind take a look when you get a chance? Thanks. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes: