Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default for the version option #3

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

andrewn617
Copy link
Collaborator

Publishing the feature failed with some schema validation errors: https://github.com/rails/devcontainer/actions/runs/8116445483/job/22186482114#step:3:71

It seems that the github action expects there to be either an enum, proposal or default in for each of the children in the options array. (source)

However, this seems wrong because both the docs and the implementation on the devcontainer cli list them as optional. I should be able to have a string option with no default and no enum / proposal options.

I want to avoid listing all the options since we will have to release a new version of the feature for every patch ruby version.

So for now it seems the best option is to add a default, altho longterm I don't think we want it. People should be explicit about the ruby version always IMO.

I will open an issue / PR to the github action to try to fix this issue. But just want to get something working for now.

@andrewn617 andrewn617 merged commit 23eb366 into main Mar 7, 2024
1 check passed
@jeremy jeremy deleted the default-for-version-option branch March 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant