Add a default for the version option #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing the feature failed with some schema validation errors: https://github.com/rails/devcontainer/actions/runs/8116445483/job/22186482114#step:3:71
It seems that the github action expects there to be either an
enum
,proposal
ordefault
in for each of the children in theoptions
array. (source)However, this seems wrong because both the docs and the implementation on the devcontainer cli list them as optional. I should be able to have a string option with no default and no enum / proposal options.
I want to avoid listing all the options since we will have to release a new version of the feature for every patch ruby version.
So for now it seems the best option is to add a default, altho longterm I don't think we want it. People should be explicit about the ruby version always IMO.
I will open an issue / PR to the github action to try to fix this issue. But just want to get something working for now.