Multiple Importmaps #279
Open
Multiple Importmaps #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If needed multiple importmaps can be defined in the `config/importmaps` directory. `bin/importmap` have a new option to work with named importmaps `bin/importmap -i admin pin "some-dependency"` The default is still `config/importmap.rb` so no change for exisiting users that does not need multiple importmaps or complexity.
|
@dhh would you consider this implementation, since it won't change anything regarding the current usage? |
|
This could also make 3rd party gems such as ActiveAdmin make it easier to work with their importmaps. As they can create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the
preloadoption was merged. But it comes with a huge penalty for a mental model. It is required for each dependency to set the preload for entrypoints. Depending on the number of items it can be hard to follow.Instead I believe this complexity can be solved with allowing multiple importmaps. But by default just work with a single one like today.
This removes the mental headache since a the dependencies in
config/importmaps/admin.rbcan be seen as a group. Without reading eachpreloadoption.This also allows to silo each importmap and reduce different dependencies to interfere with each other (e.g admin vs application).